.NET: Fix local variable naming conventions#6272
Open
XiongHaoTrigger wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Aligns local evaluation metric creation with standard C# naming conventions by renaming a local variable used to store check results.
Changes:
- Renamed
EvalCheckResulttoevalCheckResultfor camelCase local variable convention. - Updated all subsequent references to the renamed variable in metric construction and interpretation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
In
src/Microsoft.Agents.AI/Evaluation/LocalEvaluator.cs, the local variable EvalCheckResult in the EvaluateAsync method uses PascalCase naming, which violates the C# naming convention — local variables should use camelCase. PascalCase for a local variable can mislead reviewers into thinking it's a type name, reducing readability.Description
Fixed the local variable name in
src/Microsoft.Agents.AI/Evaluation/LocalEvaluator.csfrom EvalCheckResult to evalCheckResult (6 occurrences in the EvaluateAsync method) to conform to .NET camelCase naming conventions. This is a pure style fix with no logic changes.Contribution Checklist