fix: DynamicCommunitySelection crashes with KeyError when no communities at level 0#2384
Open
hanhan761 wants to merge 1 commit into
Open
fix: DynamicCommunitySelection crashes with KeyError when no communities at level 0#2384hanhan761 wants to merge 1 commit into
hanhan761 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2382
Problem
DynamicCommunitySelection.__init__atdynamic_community_selection.py:71accessesself.levels["0"]directly. When the input data contains no communities at level "0" (e.g., all communities start at level "1" or the list is empty), this raisesKeyError: '0'and crashes the dynamic community selection flow.self.levelsis built from the communities list — if no community haslevel="0", the key is never added.Fix
Replace
self.levels["0"]withself.levels.get("0", [])so thatstarting_communitiesdefaults to an empty list when no root-level communities exist.Test
Added
test_dynamic_community_selection_no_level_zerowhich creates communities only at levels 1 and 2 (no level 0) and verifies:KeyErrorselector.starting_communitiesis an empty list"0"is absent fromselector.levels