Fix whitespace-only LanceDB db_uri fallback#2391
Open
yuzhiyang1 wants to merge 1 commit into
Open
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes LanceDB vector store db_uri validation so whitespace-only values fall back to the default db_uri instead of resolving to the current working directory.
Related Issues
Fixes #2381
Proposed Changes
strip()when checking whether the LanceDB db_uri is blank.Checklist
Additional Notes
Validation run locally:
uv run pytest tests/unit/config/test_config.py -quv run ruff format packages/graphrag/graphrag/config/models/graph_rag_config.py tests/unit/config/test_config.py --checkuv run ruff check packages/graphrag/graphrag/config/models/graph_rag_config.py tests/unit/config/test_config.py