Skip to content

fix: support extended content-disposition filenames#2045

Open
cat0825 wants to merge 1 commit into
microsoft:mainfrom
cat0825:fix-content-disposition-filename-star
Open

fix: support extended content-disposition filenames#2045
cat0825 wants to merge 1 commit into
microsoft:mainfrom
cat0825:fix-content-disposition-filename-star

Conversation

@cat0825
Copy link
Copy Markdown

@cat0825 cat0825 commented Jun 1, 2026

Summary

  • support RFC 5987/RFC 2231 filename*= values in Content-Disposition response headers
  • prefer the extended filename over the fallback filename= value when both are present
  • add regression coverage for convert_response() extension detection from extended filenames

Testing

  • python -m pytest packages/markitdown/tests/test_module_misc.py -k 'content_disposition_filename'
  • OPENAI_API_KEY= hatch test from packages/markitdown
  • python -m pre_commit run --all-files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant