-
Notifications
You must be signed in to change notification settings - Fork 12
doc: clarify PeriodicTimer::poll_next() never returns None #190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add documentation to poll_next() explaining that: - Returns Poll::Ready(Some(())) when the timer ticks - Stream never completes (never returns Poll::Ready(None)) - Timer runs indefinitely - Caller is responsible for stopping via stream combinators like take() Fixes issue about missing documentation on when poll_next() returns Some vs None. Co-authored-by: martintmk <[email protected]>
Copilot
AI
changed the title
[WIP] Update documentation for PeriodicTimer::poll_next()
doc: clarify PeriodicTimer::poll_next() never returns None
Jan 8, 2026
martintmk
reviewed
Jan 8, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #190 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 106 106
Lines 6881 6881
=======================================
Hits 6881 6881 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Move documentation about stream behavior from poll_next() to the main PeriodicTimer struct documentation as requested. Made the documentation more concise while still explaining that the stream never completes. Addresses feedback on commit 01c22dd Co-authored-by: martintmk <[email protected]>
sandersaares
approved these changes
Jan 8, 2026
martintmk
approved these changes
Jan 8, 2026
Member
|
@copilot Can you add the word "combinators" to the repo's dictionary and make sure the spell check CI gate passes? |
geeknoid
approved these changes
Jan 8, 2026
Add the word 'combinators' to .spelling dictionary file to fix spell check CI gate. The word is used in the PeriodicTimer documentation when describing stream combinators like take(). Co-authored-by: geeknoid <[email protected]>
Contributor
Author
geeknoid
approved these changes
Jan 8, 2026
geeknoid
approved these changes
Jan 8, 2026
tekian
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation Update for PeriodicTimer::poll_next()
PeriodicTimerstruct explaining stream behaviorSummary
Successfully added concise documentation to
PeriodicTimerstruct explaining:Streamand never completesStreamExt::take()to limit ticksAdded 'combinators' to the repository's spell check dictionary to ensure CI passes.
All tests pass (123 unit tests + 48 doc tests).
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.