docs: fix Firefox patch comment typos#40897
Closed
LeSingh1 wants to merge 1 commit into
Closed
Conversation
Collaborator
|
This fix is too minor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two spelling typos in a comment in the Firefox page handler patch.
Files changed
browser_patches/firefox/juggler/protocol/PageHandler.js:non-overriden->non-overridden,priveleged->privilegedBefore / after
Before, the comment describing the
devicePixelRatiobehavior contained two misspellings. After, the comment text is corrected with no behavior change.Verification
rg "overriden|priveleged" browser_patches/firefox/juggler/protocol/PageHandler.jsand confirmed no matches.Competing PR check
Checked for existing PRs with:
gh pr list --repo microsoft/playwright --search "priveleged PageHandler" --state all --limit 10gh pr list --repo microsoft/playwright --search "overriden devicePixelRatio" --state all --limit 10No matching PRs were returned.