Require recent NES trigger before triggering on document switch #2918
+58
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes microsoft/vscode#284225 Previously, switching documents could trigger NES even when NES hadn't been recently active, causing unexpected suggestions to appear. This change adds a check in `_maybeTriggerOnDocumentSwitch` to require that NES was triggered within the last 10 seconds before allowing a document switch to trigger a new NES request. This aligns the document switch behavior with the existing same-document behavior, which already requires a recent NES trigger via the `hasRecentTrigger` check.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where Next Edit Suggestions (NES) could be unexpectedly triggered when switching documents even when NES hadn't been recently active. The change adds a check to require that NES was triggered within the last 10 seconds before allowing a document switch to trigger a new NES request.
Changes:
- Added a
lastTriggerTimecheck in_maybeTriggerOnDocumentSwitchto align document switch behavior with existing same-document behavior - Added comprehensive tests to verify NES is not triggered on document switch when there's no recent trigger, and is triggered when there is a recent trigger
- Minor test infrastructure improvements (extracting
triggerTextSelectionChangeWithKindhelper and fixingcreateTextDocumentto use passed parameters)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/extension/inlineEdits/vscode-node/inlineEditModel.ts | Added lastTriggerTime check (lines 284-289) in _maybeTriggerOnDocumentSwitch to require recent NES activity before triggering on document switch |
| src/extension/inlineEdits/test/vscode-node/inlineEditModel.spec.ts | Added two new tests covering document switch behavior with stale vs recent NES triggers, extracted helper function, and fixed test utility to properly use parameters |
Member
Author
|
fyi @ulugbekna |
dmitrivMS
approved these changes
Jan 16, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/vscode#284225
Previously, switching documents could trigger NES even when NES hadn't been recently active, causing unexpected suggestions to appear. This change adds a check in
_maybeTriggerOnDocumentSwitchto require that NES was triggered within the last 10 seconds before allowing a document switch to trigger a new NES request.This aligns the document switch behavior with the existing same-document behavior, which already requires a recent NES trigger via the
hasRecentTriggercheck.