Fix: Copy in Output pane respects active filters #287164
Draft
+266
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add FilteredCopyHandler contribution to intercept copy events - Filter copied text to exclude hidden areas when filter is active - Expose hidden areas from FilterController - Only applies filtering when there are hidden areas (filter active) Co-authored-by: joaomoreno <[email protected]>
- Use line-by-line approach for better clarity - Add isLineHidden helper method - Simplify splitRangeByHiddenAreas implementation Co-authored-by: joaomoreno <[email protected]>
Co-authored-by: joaomoreno <[email protected]>
The clipboardService was injected but not used since copy is handled directly via ClipboardEvent's clipboardData property. Co-authored-by: joaomoreno <[email protected]>
- Remove unused createModel function from test - Add comment explaining manual listener lifecycle management - Optimize getVisibleTextToCopy to avoid redundant hidden areas lookup - Pass hiddenAreas as parameter instead of fetching twice Co-authored-by: joaomoreno <[email protected]>
- Use ClipboardEventUtils.setTextData() for consistency with VS Code clipboard handling - Use DisposableStore pattern for listener management (follows FilterController pattern) - Fix getLineMaxColumn fallback to return early if model is null - Remove custom dispose() override as it's now handled by DisposableStore Co-authored-by: joaomoreno <[email protected]>
- Remove unused imports from test file (OutputEditor, TextModel, URI, ITextModel) - Remove unused IDisposable import from outputView.ts - Add comment explaining ClipboardStoredMetadata version number - Extract column calculation helpers to reduce code duplication - Add getStartColumn() and getEndColumn() helper methods Co-authored-by: joaomoreno <[email protected]>
Copilot
AI
changed the title
[WIP] Fix copying of visible logs from Output pane
Fix: Copy in Output pane respects active filters
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a filter is active in the Output pane, copying (Ctrl+A + Ctrl+C) currently copies all content including hidden/filtered lines. This makes filtered logs difficult to process.
Changes
getHiddenAreas()to surface currently hidden rangesClipboardEventUtilsfor consistency with VS Code clipboard operationsImplementation Details
The handler splits selection ranges by iterating through lines and checking if each line falls within a hidden area. Visible sub-ranges are extracted and concatenated with proper EOL characters. When no filter is active, default copy behavior is preserved.
Resource management follows the established
DisposableStorepattern used inFilterController. The copy listener is re-attached when the editor model changes.Testing
Manual testing required: Apply filter in Output pane → select and copy content → verify only visible lines are copied to clipboard.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.