fix: stop event propagation on Enter key in find and replace inputs#301635
Open
tamuratak wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: stop event propagation on Enter key in find and replace inputs#301635tamuratak wants to merge 1 commit intomicrosoft:mainfrom
tamuratak wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a keybinding double-dispatch in the editor Find/Replace widget by preventing the Ctrl+Enter keydown event from bubbling to the global keybinding listener after it has already been dispatched locally (addresses #299353).
Changes:
- Stop event propagation for
Ctrl+Enterin the Find input keydown handler after dispatching (or inserting a newline). - Stop event propagation for
Ctrl+Enterin the Replace input keydown handler after dispatching (or inserting a newline).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: stop event propagation on Enter key in find and replace inputs. Fix #299353