Fix ctx.log type to accept any JSON-serializable type#2330
Open
qianchongyang wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Fix ctx.log type to accept any JSON-serializable type#2330qianchongyang wants to merge 1 commit intomodelcontextprotocol:mainfrom
qianchongyang wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
According to the MCP spec, the data that may be logged can be of any type, not just str. This change updates the logging context methods to accept Any instead of str for the data parameter. Changes: - Change 'message' parameter to 'data' with type Any in log() - Update all convenience methods (debug, info, warning, error) to accept Any for the data parameter - Update docstring to reflect the spec-compliant behavior Fixes modelcontextprotocol#397
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
ctx.infoand similar logging methods havemessage: strtype, but the MCP spec definesdata: unknownto allow any JSON-serializable type. This inconsistency causes type errors when trying to log non-string data.Solution
Updated type hints for logging methods to accept
unknowninstead ofstr:message: strtomessage: unknowninctx.info,ctx.debug, etc.extraparameter documentationLoggingMessageNotificationParamsandsend_log_messagesignaturesValidation
Fixes #397