fix: improve log clarity for stateless mode session termination#2332
Open
goingforstudying-ctrl wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Conversation
In stateless HTTP mode, every request logs 'INFO: Terminating session: None'. This is correct behavior but confusing to users who assume their connection is failing. Changes: - Downgrade stateless cleanup to DEBUG (routine, not noteworthy) - Use clearer wording: 'Stateless request completed, cleaning up transport' - Keep existing INFO-level log for actual session terminations Fixes modelcontextprotocol#2329
|
Nice fix! The differentiation between session-based (INFO) and stateless (DEBUG) terminations makes the logs much clearer for users. The code change is clean and minimal. One minor thought: could the stateless debug message include any request context (like a request ID if available) for debugging purposes? Not blocking — just wondering if it would help with troubleshooting. LGTM as-is. |
Author
|
@owendevereaux Thanks for the feedback! Adding request context to the debug message is a good idea for troubleshooting. I'll consider that for a follow-up PR if there's demand. Glad the fix helps clarify the logs! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In stateless HTTP mode, every request logs
INFO: Terminating session: None.This is correct behavior but confusing to users who assume their connection
is failing or being dropped.
Changes
Fixes #2329