refactor: import SSEError from httpx_sse public API#2560
Merged
Conversation
`SSEError` is re-exported at the `httpx_sse` package top level and listed in `__all__` in every release >=0.4.0; the `_exceptions` submodule is private. Importing via the public path avoids breakage if httpx-sse reorganises its internals. No behaviour change (same class object).
6 tasks
bhosmer-ant
approved these changes
May 8, 2026
Contributor
bhosmer-ant
left a comment
bhosmer-ant
left a comment
There was a problem hiding this comment.
Verified SSEError is re-exported and listed in __all__ at the httpx-sse>=0.4 floor (0.4.0), so this is safe across the full supported range. Same class object, no behaviour change. lowest-direct matrix legs confirm.
Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/mcp/client/sse.pyimportsSSEErrorfrom the privatehttpx_sse._exceptionssubmodule (introduced in #975).SSEErroris part of httpx-sse's public API — re-exported at the package top level and listed in__all__in every release ≥0.4.0 — so this switches to the public path.Motivation and Context
Underscore-prefixed modules are private; httpx-sse could reorganise
_exceptions.pyin any patch release without it being a breaking change. The public re-export is the stable surface.Surfaced while investigating #2543.
How Has This Been Tested?
Verified
from httpx_sse import SSEErrorworks against every published httpx-sse ≥0.4 (0.4.0, 0.4.1, 0.4.2, 0.4.3) and that it resolves to the identical class object as the private path. CI'slowest-directmatrix exercises httpx-sse==0.4.0 directly.Breaking Changes
None — same class object, no behaviour change.
Types of changes
Checklist
AI Disclaimer