OAuth Client Provider for Streamable HTTP Client#681
Closed
aravind-segu wants to merge 3 commits intomodelcontextprotocol:mainfrom
Closed
OAuth Client Provider for Streamable HTTP Client#681aravind-segu wants to merge 3 commits intomodelcontextprotocol:mainfrom
aravind-segu wants to merge 3 commits intomodelcontextprotocol:mainfrom
Conversation
Contributor
|
Thank you @aravind-segu!! Sorry I just saw this one, as discussed in previous PRs, we should have support for Auth in Client now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Issue: #652
Introduces a OAuthProvider for Streamable HTTP Client, which allows to authenticate to the HTTP Client through the OAuth. This follows a similar architecture to the typescript auth provider: https://github.com/modelcontextprotocol/typescript-sdk/blob/621ccea997bf318ee99c7f64ce19609e838615fa/src/client/auth.ts#L13
How Has This Been Tested?
Unit tests, and tested with Databricks OAuth App
Breaking Changes
streamablehttp_client() now returns a finish_auth method which needs to be called after the OAuth redirect. If the users were unpacking this as a tuple, they now can get an extra return value in the tuple. This is not a big breaking change, but might error out for some users depending on their implementation.
Types of changes
Checklist
Additional context