Skip to content

chore: remove the rig example#763

Open
jokemanfire wants to merge 1 commit intomodelcontextprotocol:mainfrom
jokemanfire:rig
Open

chore: remove the rig example#763
jokemanfire wants to merge 1 commit intomodelcontextprotocol:mainfrom
jokemanfire:rig

Conversation

@jokemanfire
Copy link
Member

The rig official has the mcp example, we need not to keep it just give the link.

Motivation and Context

Reduce example maintenance work

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

The rig official has the mcp example, we need not to keep it just give the link.
Signed-off-by: jokemanfire <hu.dingyang@zte.com.cn>
Copilot AI review requested due to automatic review settings March 20, 2026 08:58
@github-actions github-actions bot added T-documentation Documentation improvements T-dependencies Dependencies related changes T-config Configuration file changes T-examples Example code changes labels Mar 20, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the in-repo rig-integration example to reduce maintenance burden, and replaces its listing in the examples index with a link to the upstream Rig MCP example.

Changes:

  • Deleted the examples/rig-integration example crate (source, config, and manifest).
  • Updated examples/README.md to point the Rig integration example to the upstream Rig repository.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
examples/rig-integration/src/mcp_adaptor.rs Removed Rig↔MCP adaptor implementation as part of deleting the example.
examples/rig-integration/src/main.rs Removed the example CLI entrypoint.
examples/rig-integration/src/config/mcp.rs Removed MCP transport/server config for the example.
examples/rig-integration/src/config.rs Removed example configuration loader/types.
examples/rig-integration/src/chat.rs Removed streaming CLI chat UI for the example.
examples/rig-integration/config.toml Removed example runtime configuration.
examples/rig-integration/Cargo.toml Removed the example crate manifest from the workspace glob.
examples/README.md Replaced local Rig example link with an external upstream link.

Copy link
Member

@DaleSeo DaleSeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up, @jokemanfire!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-config Configuration file changes T-dependencies Dependencies related changes T-documentation Documentation improvements T-examples Example code changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants