fix(memory): strip extra properties from entities/relations to fix schema validation#3634
Open
ctonneslan wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Conversation
…output read_graph, search_nodes, and open_nodes fail with schema validation error when the memory.jsonl file contains entities with additional properties not in the EntitySchema (e.g. custom_id from older versions or external tools). The MCP SDK validates structuredContent against the outputSchema and rejects entities with extra fields. Now strips entities and relations to only include schema-defined fields before returning. Fixes modelcontextprotocol#3144
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
read_graph,search_nodes, andopen_nodesfail with:This happens when the
memory.jsonlfile contains entities with extra properties not defined inEntitySchema(e.g.custom_id, metadata from older versions, or properties added by external tools).The MCP SDK validates
structuredContentagainst theoutputSchemaand rejects entities with extra fields.Fix
Strip entities and relations to only include schema-defined fields before returning in all three graph-returning tools:
This ensures the output matches the schema while preserving all data in the underlying JSONL file (extra properties are still stored, just not returned in the structured output).
Fixes #3144