Skip to content

fix: include scope parameter in OAuth authorization code token exchange #1669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vadaski wants to merge 1 commit into
base: main
Choose a base branch
from
+122 −6

fix: include scope in OAuth authorization code token exchange (#941)

98dd73a
Select commit
Loading
Failed to load commit list.
Open

fix: include scope parameter in OAuth authorization code token exchange #1669

fix: include scope in OAuth authorization code token exchange (#941)
98dd73a
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Mar 27, 2026 in 5m 5s

Code review found 2 potential issues

Found 5 candidates, confirmed 2. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit packages/client/src/client/auth.ts:1208-1210 exchangeAuthorization not updated to accept/forward scope

Annotations

Check warning on line 1210 in packages/client/src/client/auth.ts

See this annotation in the file changed.

@claude claude / Claude Code Review

exchangeAuthorization not updated to accept/forward scope 

Nit: `exchangeAuthorization()` was not updated to accept or forward a `scope` parameter, even though this PR added scope support to `prepareAuthorizationCodeRequest()` which it calls (line 1324). This is a consistency gap — callers using `exchangeAuthorization()` directly cannot pass scope through to the token request. Not a regression since this function never had scope support before, but worth adding for API completeness.
View more details on Claude