fix: widen elicitInput requestedSchema type for Zod compatibility#1685
Closed
travisbreaks wants to merge 1 commit intomodelcontextprotocol:mainfrom
Closed
fix: widen elicitInput requestedSchema type for Zod compatibility#1685travisbreaks wants to merge 1 commit intomodelcontextprotocol:mainfrom
travisbreaks wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
…ema output Zod v4's `.toJSONSchema()` produces standard JSON Schema output that includes fields like `$schema` and `additionalProperties`. The `requestedSchema` type in `ElicitRequestFormParams` was too narrow to accept these extra fields, forcing users to cast through `unknown`. This adds `.passthrough()` to the Zod runtime schema and an index signature to the spec type, allowing any additional JSON Schema fields through while keeping the required fields (`type`, `properties`) strictly typed. Fixes modelcontextprotocol#1362 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: e5b1274 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
Author
|
Duplicate of #1686. Closing this one in favor of the cleaner PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Widens the
requestedSchematype inelicitInputto accept standard JSON Schema output from Zod's.toJSONSchema(), fixing the type incompatibility reported in #1362.The problem: Zod v4's
.toJSONSchema()returns objects with extra standard JSON Schema fields ($schema,additionalProperties, etc.). The SDK'srequestedSchematype was a closed object that rejected these at the type level, forcing users to cast throughunknown.The fix (minimal, two changes):
types.ts: Added.passthrough()to the Zod schema so extra fields pass runtime validationspec.types.ts: Added[key: string]: unknownindex signature to match the widened Zod typeRequired fields (
type: 'object',properties) remain strictly typed.Test plan
spec.types.test.tsmutual-assignability checks)@modelcontextprotocol/core)Fixes #1362.
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com