Merged
Conversation
- Plumb fee_estimator into LiquiditySource for splice UTXO selection - Add splice_channel_for_lsps4() helper mirroring Node::splice_in() - Add open_channel_for_lsps4() helper extracted from OpenChannel handler - Handle SpliceChannel event: try splice, fallback to create_channel - Wire SpliceFailed to reset LSPS4 liquidity cooldown - Wire ChannelClosed to clear LSPS4 liquidity cooldown - Switch to local path deps for cross-repo development
Switch from lsp-0.2.0 (55f7619) to feature/lsps4-splice-in (f6c56daa9) which includes the LSPS4 splice-in support.
Update to afe7b5bb0 which includes splice unit tests.
When splice fails because the channel is reestablishing (not usable yet), don't fall back to create_channel. The timer retries in ~1s once reestablishment completes.
Splices are zero-conf anyway, so using unconfirmed inputs adds no additional risk. Prevents splice failures when the LSP wallet has unconfirmed change from a previous splice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle SpliceChannel events and wire lifecycle hooks