-
Notifications
You must be signed in to change notification settings - Fork 1.3k
CSHARP-5838: Clarify interaction between TLS errors and backpressure #1851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR temporarily disables backpressure error label functionality by commenting out the implementation in AddBackpressureErrorLabelsIfRequired. The change is being made for release purposes to address potential issues with the interaction between TLS errors and backpressure handling.
Changes:
- Commented out the backpressure error labeling logic in
BinaryConnection.cs
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // if (exception == null) | ||
| // { | ||
| // return; | ||
| // } | ||
| // | ||
| // if (exception.ContainsTimeoutException || exception.InnerException is IOException) | ||
| // { | ||
| // exception.AddErrorLabel("SystemOverloadedError"); | ||
| // exception.AddErrorLabel("RetryableError"); | ||
| // } |
Copilot
AI
Jan 14, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The entire method body is commented out, leaving a no-op method that still accepts a parameter. Consider either removing the method entirely if it's not being called, or adding a clear TODO comment explaining why this is temporarily disabled and when it should be re-enabled. This will prevent confusion for future maintainers.
| // if (exception == null) | |
| // { | |
| // return; | |
| // } | |
| // | |
| // if (exception.ContainsTimeoutException || exception.InnerException is IOException) | |
| // { | |
| // exception.AddErrorLabel("SystemOverloadedError"); | |
| // exception.AddErrorLabel("RetryableError"); | |
| // } | |
| // TODO: Backpressure-related error labeling is intentionally disabled. | |
| // This method is currently a no-op and preserved only to maintain API/behavioral | |
| // compatibility with existing callers. If backpressure handling is reintroduced, | |
| // consider adding appropriate error labels (for example, for timeout or IO-related | |
| // exceptions) here to support any desired retry or diagnostics behavior. |
BorisDog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Disable the backpressure changes for the release purposes.
d772bd1 to
7e2b88b
Compare
Disable the backpressure changes for the release purposes.