Skip to content

Conversation

@sanych-sun
Copy link
Member

Disable the backpressure changes for the release purposes.

@sanych-sun sanych-sun requested a review from a team as a code owner January 14, 2026 23:38
@sanych-sun sanych-sun added the chore Non–user-facing code changes (tests, build scripts, etc.). label Jan 14, 2026
@sanych-sun sanych-sun requested review from Copilot and papafe January 14, 2026 23:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR temporarily disables backpressure error label functionality by commenting out the implementation in AddBackpressureErrorLabelsIfRequired. The change is being made for release purposes to address potential issues with the interaction between TLS errors and backpressure handling.

Changes:

  • Commented out the backpressure error labeling logic in BinaryConnection.cs

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +598 to +608
// if (exception == null)
// {
// return;
// }
//
// if (exception.ContainsTimeoutException || exception.InnerException is IOException)
// {
// exception.AddErrorLabel("SystemOverloadedError");
// exception.AddErrorLabel("RetryableError");
// }
Copy link

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The entire method body is commented out, leaving a no-op method that still accepts a parameter. Consider either removing the method entirely if it's not being called, or adding a clear TODO comment explaining why this is temporarily disabled and when it should be re-enabled. This will prevent confusion for future maintainers.

Suggested change
// if (exception == null)
// {
// return;
// }
//
// if (exception.ContainsTimeoutException || exception.InnerException is IOException)
// {
// exception.AddErrorLabel("SystemOverloadedError");
// exception.AddErrorLabel("RetryableError");
// }
// TODO: Backpressure-related error labeling is intentionally disabled.
// This method is currently a no-op and preserved only to maintain API/behavioral
// compatibility with existing callers. If backpressure handling is reintroduced,
// consider adding appropriate error labels (for example, for timeout or IO-related
// exceptions) here to support any desired retry or diagnostics behavior.

Copilot uses AI. Check for mistakes.
@sanych-sun sanych-sun requested review from BorisDog and removed request for papafe January 14, 2026 23:39
Copy link
Contributor

@BorisDog BorisDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Disable the backpressure changes for the release purposes.
@sanych-sun sanych-sun merged commit 8aef3e8 into mongodb:main Jan 15, 2026
57 of 61 checks passed
@sanych-sun sanych-sun deleted the csharp5838 branch January 15, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Non–user-facing code changes (tests, build scripts, etc.).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants