JsonBsonEncoder: fix parsing of JsonPrimitive numbers#1937
Open
berlix wants to merge 1 commit intomongodb:mainfrom
Open
JsonBsonEncoder: fix parsing of JsonPrimitive numbers#1937berlix wants to merge 1 commit intomongodb:mainfrom
berlix wants to merge 1 commit intomongodb:mainfrom
Conversation
encodeJsonPrimitive would in some cases attempt to parse scientifically formatted numbers as plain Ints/Longs, which would result in a NumberFormatException.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
encodeJsonPrimitivewould in some cases attempt to parse scientifically formatted numbers as plain Ints/Longs, which would result in aNumberFormatException.The new test case
testJsonPrimitiveNumberEncodingreproduces the issue/verifies the fix.Note that the adjusted implementation always encodes numbers with the least amount of decimals necessary, which is why some other test cases needed to be adjusted.