Close connection on responseTo mismatch to prevent pool reuse#1975
Closed
rozza wants to merge 2 commits into
Closed
Close connection on responseTo mismatch to prevent pool reuse#1975rozza wants to merge 2 commits into
rozza wants to merge 2 commits into
Conversation
When ReplyMessage detects that the responseTo field in a server response does not match the expected requestId, close the underlying connection. Previously, MongoInternalException propagated as a regular error without closing the stream. Since PooledConnection.close() only prunes connections that are closed or match shouldPrune() criteria (generation, idle time, lifetime), the desynchronized connection was returned to the pool and could be handed to subsequent operations — risking further data corruption. A responseTo mismatch means the TCP stream is definitively desynchronized. The connection is unusable and must not be recycled. JAVA-6210 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Assigned |
Member
Author
|
Working on more defensive hardening and will repurpose JAVA-6210 to cover all these cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ReplyMessage detects that the responseTo field in a server response does not match the expected requestId, close the underlying connection.
Previously, MongoInternalException propagated as a regular error without closing the stream. Since PooledConnection.close() only prunes connections that are closed or match shouldPrune() criteria (generation, idle time, lifetime), the desynchronized connection was returned to the pool and could be handed to subsequent operations — risking further data corruption.
A responseTo mismatch means the TCP stream is definitively desynchronized. The connection is unusable and must not be recycled.
JAVA-6210