-
Notifications
You must be signed in to change notification settings - Fork 0
[AE-1142] Include ad client country, region, and dma in the interaction and request-stats pings #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
16fb96b to
d5a6075
Compare
gleonard-m
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was a data collection review created for this?
No I didn't do a data review for this change, is it needed? My thought was we're already collecting this data in other pings, and in some cases in other fields of the same ping, but I'm happy to kick that off now if necessary |
| country_code: | ||
| type: string | ||
| description: > | ||
| Country code (ISO 3166-1 alpha-2 format) associated with the client when the ad was requested. | ||
| Should not be null. | ||
| lifetime: application | ||
| send_in_pings: | ||
| - interaction | ||
| - provider-request-stats | ||
| - request-stats |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
country code is already in the interaction ping, looks like we have two metrics with the same name but under different groups
mars-telemetry/telemetry/glean/metrics.yaml
Lines 123 to 131 in 3cad719
| country_code: | |
| type: string | |
| description: > | |
| Country code associated with the client when the ad was requested. | |
| Should not be null. | |
| lifetime: application | |
| send_in_pings: | |
| - interaction | |
| - request-stats |
| send_in_pings: | ||
| - interaction | ||
| - provider-request-stats | ||
| - request-stats |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similar for region code, we have a separately named metric in these pings
mars-telemetry/telemetry/glean/metrics.yaml
Lines 141 to 150 in 3cad719
| region_code: | |
| type: string | |
| description: > | |
| Region code associated with the client when the ad was requested. May | |
| be null. | |
| lifetime: application | |
| send_in_pings: | |
| - interaction | |
| - request-stats | |
| notification_emails: |
| - interaction | ||
| - provider-request-stats | ||
| - request-stats |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I don't see dma code present on interaction or request-stats yet. One thing that may be annoying about glean is that the fields in the table get named based on the groupings in the schema, so this would make the interactions table have field ad.country_code, ad.region_code, and ad_client.dma. maybe not a real issue since the existing fields are already an arbitrary seeming mixture of prefixes https://dictionary.telemetry.mozilla.org/apps/ads_backend/pings/interaction?page=1
Tickets or other relevant links:
https://mozilla-hub.atlassian.net/browse/AE-1142
What's Here
In preparation for rolling out OHTTP between Desktop FFox and MARS, we need to capture all the ad client's geo fields in all our pings -- specifically the interaction and request-stats ping.
Things I'd Like Feedback On
Lmk if you see any issues with capturing this. Looks like it is already available in the backend.
Testing
This can be tested via the companion PR in MARS that use the updated pings structure, see the Testing section there.
Any concerns with backwards compatibility?
No, these changes are additive.