Support bends and dives on the same notes #31698
Open
+258
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-spa
force-pushed
the
supportBendsAndDivesOnSameNotes
branch
4 times, most recently
from
2b84ef0 to
77853ca
Compare
miiizen
approved these changes
Jan 16, 2026
src/engraving/dom/guitarbend.cpp
Outdated
| } | ||
| if (isValid) { | ||
| if (bendType() == GuitarBendType::PRE_BEND) { | ||
| Note* startN = prevBend->startNote(); |
| if (bendType() == GuitarBendType::PRE_DIVE || bendType() == GuitarBendType::PRE_BEND) { | ||
| GuitarBend* prevBend = findPrecedingBend(); | ||
| if (prevBend && prevBend->holdLine()) { | ||
| mutldata()->setBendDigit(u""); |
Contributor
There was a problem hiding this comment.
I overlooked this previously, but it feels like computeBendText should be part of the layout code. It would be good to avoid manipulating layout data in the DOM as much as possible.
Contributor
Author
There was a problem hiding this comment.
That's a good point, but it's a bit of a mixed situation, because this function is called by GuitarBend::computeBendAmount which then should be also moved to the layout code, but then one could argue that the bend amount is really not layout information but intrinsic DOM information. I definitely need to clean this up but it will have to wait for the next PR
mike-spa
force-pushed
the
supportBendsAndDivesOnSameNotes
branch
from
8369f48 to
5be4cf6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #31292