Use correct file reader for palettes and migrate old workspaces #31719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbjeukendrup
approved these changes
Jan 9, 2026
miiizen
force-pushed
the
migratePalettes
branch
from
e0f7df6 to
720223c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds file version numbers to user's palette files. Previously, these were unversioned and the latest file reader would be used no matter which version the file had last been saved in. This has caused lots of bugs and complicated migration between versions.
We probably won't need to add anything new to
PaletteCompat::migrateOldPaletteCellIfNeeded. The migration in here should be covered by migration code we are adding in the mscx reader anyway.