Enable full MIDI note support (0-127 instead of 12-108) in VST sequencer #31784
+32
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables full MIDI note support in the VST Sequencer. It doesn't touch fluidsynth or MuseSampler, but similar noteIndex and noteTuning methods in fluidsequencer.cpp and musesamplersequencer.cpp could be ported in subsequent PRs.
While ideally this should be fixed in pitchutils.h as described in #16657, this small PR unlocks full VST instrument and keyswitch support for the short term and incurs little tech debt as only two methods are changed.
Tested with Vital Synth, Kontakt 8, Sine Player, Synchron Player, Spitfire Player, MuseSounds, MS Basic.
Resolves: #16657