feat: improve tablet and large-screen navigation layout by mykh-hailo · Pull Request #16764 · nextcloud/android

mykh-hailo · 2026-03-27T20:53:09Z

Summary

This change adapts the main file browser and several activities for tablets and wide layouts (typically sw600dp / w600dp) by using a persistent navigation column next to content instead of relying only on the sliding DrawerLayout pattern used on phones.

Closes: #14871

DrawerActivity is updated so drawer behavior works when the root layout is not a DrawerLayout (e.g. ConstraintLayout with a fixed-width nav region). Alternative layouts under layout-sw600dp align Compose, Navigator, Contacts preferences, Synced folders, and Upload list with the same idea. files.xml is refactored to support the sidebar + content structure and to keep ViewBinding (FilesBinding / drawer_menu) consistent. TrashbinActivity and toolbar_standard are adjusted for the new structure. New sidebar.xml and resource tweaks (bools, dims) support the tablet configuration.

Technical notes

DrawerActivity: Centralizes “menu layout” handling; drawer toggle, ActionBarDrawerToggle, and related APIs run only when the root is a DrawerLayout; optional hamburger visibility when the layout does not use a sliding drawer.
Resource qualifiers: layout-sw600dp (and related values-*) provide wide-screen layouts without affecting default (phone) resources.
File display: files.xml + sidebar.xml structure; FileDisplayActivity updated as needed for binding / initialization.
Consistency: Trashbin and toolbar spacing tweaks aligned with the new app bar / content arrangement.

mykh-hailo · 2026-03-27T20:54:38Z

@alperozturk96 Could you please check my PR for the tablet view?
Any feedback and advice is always welcome

alperozturk96

Hello, thank you for your PR.

Since these changes affect multiple screens, they will require thorough testing. To help the review process, could you please limit the scope to a single screen with minimal changes for now? Once that is reviewed and validated, we can proceed incrementally.

Additionally, please:

Exclude any .salive files from the PR (I updated gitignore)
Remove comments that restate obvious information (e.g., field descriptions that are self-explanatory)
Follow camelCase naming conventions (e.g., sidebarQuotaView instead of mSidebarQuotaView)

Thanks again for your contribution.

mykh-hailo · 2026-03-30T12:53:24Z

@alperozturk96 Thank you for the updates.
All the code that handles the sidebar and drawer menu is implemented DrawerActivity, and it adapts to different screen sizes. I've also added the sidebar layout to the XML files where needed.

I initially tired to create a patch that only affects FileDisplayActivity, but it turns out that all related changes are required, except for the XML layouts. However, if the XML layouts for other activities are not updated, it may cause error during testing.

Could you advise on a simpler way to handle this so it's easier to test?

mykh-hailo · 2026-04-09T16:31:30Z

@alperozturk96 I'd appreciate it if I can continue to work this issue.

github-actions · 2026-04-11T02:13:01Z

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

mykh-hailo · 2026-04-13T19:50:19Z

@alperozturk96 Can you provide me any updates on this issue?
Can you go ahead with this issue now?

alperozturk96 · 2026-04-14T07:22:13Z

@tobiasKaminsky Could you please share your feedback?

mykh-hailo · 2026-04-15T13:07:35Z

@alperozturk96 , @tobiasKaminsky I'd appreciate if you can provide any update on this PR.

alperozturk96

Hello

Thank you for the PR 👍

alperozturk96 · 2026-04-15T13:35:38Z

        }
    }

+    private View findSidebarQuotaViewById(int id) {


Can we extract whole new sidebar logic to the new Kotlin class and use reference here since DrawerActivity already too big.

@alperozturk96 I updated the code for your comment here.
Could you possibly review it please?

alperozturk96 · 2026-04-15T13:36:35Z

    private NavigationView drawerNavigationView;

+    private View sidebarMenu;
+    private NavigationView sidebarNavigationView;


Could you please add screen-shot tests for tablet and phone?

@alperozturk96 Here is screenshots.

Phone(Portrait)

Phone(Landscape)

Tablet

Signed-off-by: mykh-hailo <kristianderonta0205@gmail.com>

AndyScherzinger requested a review from alperozturk96 March 27, 2026 21:13

AndyScherzinger added enhancement design 3. to review labels Mar 27, 2026

AndyScherzinger requested a review from tobiasKaminsky March 27, 2026 21:14

mykh-hailo force-pushed the feat/tablet-ux branch from cef7b13 to a15915f Compare March 27, 2026 21:27

alperozturk96 requested changes Mar 30, 2026

View reviewed changes

mykh-hailo force-pushed the feat/tablet-ux branch 2 times, most recently from 4136dae to 97bafb0 Compare March 30, 2026 19:15

This comment was marked as resolved.

Sign in to view

This comment was marked as off-topic.

Sign in to view

github-actions bot added the feedback-requested label Apr 11, 2026

alperozturk96 requested changes Apr 15, 2026

View reviewed changes

feat: imporve tablet and large-screen navigationlayout

bd72a9e

Signed-off-by: mykh-hailo <kristianderonta0205@gmail.com>

mykh-hailo force-pushed the feat/tablet-ux branch from 97bafb0 to bd72a9e Compare April 15, 2026 15:36

fix: extract sidebar logic in a separate class

bfaeccf

Signed-off-by: mykh-hailo <kristianderonta0205@gmail.com>

Uh oh!

Conversation

mykh-hailo commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Technical notes

Uh oh!

mykh-hailo commented Mar 27, 2026

Uh oh!

alperozturk96 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mykh-hailo commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as off-topic.

This comment was marked as off-topic.

mykh-hailo commented Apr 9, 2026

Uh oh!

github-actions bot commented Apr 11, 2026

Uh oh!

mykh-hailo commented Apr 13, 2026

Uh oh!

alperozturk96 commented Apr 14, 2026

Uh oh!

mykh-hailo commented Apr 15, 2026

Uh oh!

alperozturk96 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alperozturk96 Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

mykh-hailo Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

alperozturk96 Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

mykh-hailo Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Phone(Portrait)

Phone(Landscape)

Tablet

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mykh-hailo commented Mar 27, 2026 •

edited

Loading

alperozturk96 left a comment •

edited

Loading

mykh-hailo commented Mar 30, 2026 •

edited

Loading

mykh-hailo Apr 15, 2026 •

edited

Loading