refactor: drop moment from new bundles #57503
Merged
+226
−256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
nfebe and
szaimen
and removed request for
a team
susnux
added
the
♻️ refactor
susnux
force-pushed
the
chore/drop-moment
branch
from
8930444 to
3f79e79
Compare
ShGKme
reviewed
Jan 13, 2026
susnux
force-pushed
the
chore/drop-moment
branch
from
3f79e79 to
48a0a1f
Compare
Merged
CarlSchwan
approved these changes
Jan 13, 2026
On the Vue 3 side lets remove the dependency on Moment as this is a pretty huge dependency. Instead use plain Intl API for formatting. This reduces the bundle size by ~1.5MiB. Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
chore/drop-moment
branch
from
48a0a1f to
a623bff
Compare
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the Vue 3 side lets remove the dependency on Moment as this is a pretty huge dependency. Instead use something tiny like dayjs for date computation (end of week / end of day) and use plain Intl API for formatting.
This reduces the bundle size by 9%.
Checklist
3. to review, feature component)stable32)