[stable33] fix(zip): Fix warning when downloading Zip file#59383
Merged
[stable33] fix(zip): Fix warning when downloading Zip file#59383
Conversation
backportbot
bot
requested review from
ArtificialOwl,
CarlSchwan,
icewind1991,
leftybournes,
salmart-dev,
skjnldsv and
susnux
and removed request for
a team,
skjnldsv and
susnux
backportbot
bot
added
3. to review
skjnldsv
approved these changes
Apr 1, 2026
Merged
CarlSchwan
approved these changes
Apr 3, 2026
The HEAD request, create a GET subrequest which is not compatible with the ZIP plugin since the ZIP plugin is directly streaming the content to php://output, so we were sending the content in a HEAD request and creating the ZIP twice and this was creating various warning in logs too. Signed-off-by: Carl Schwan <carlschwan@kde.org>
susnux
force-pushed
the
backport/59372/stable33
branch
from
792bc66 to
d438db4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #59372