fix(systemtags): only render inline list of tags if there are some#59424
Open
fix(systemtags): only render inline list of tags if there are some#59424
Conversation
susnux
requested review from
Antreesy and
skjnldsv
and removed request for
sorbaugh
Contributor
Author
|
/backport to stable33 |
Contributor
Author
|
/backport to stable32 |
susnux
force-pushed
the
fix/systemtags-inline
branch
from
5ec9b42 to
d4e6790
Compare
- resolves #59332 If there are no tags available, then we cannot render an `<ul>` element as this would result in invalid HTML / invalid accessibility state. Ref: https://www.w3.org/TR/wai-aria-1.2/#mustContain Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/systemtags-inline
branch
from
d4e6790 to
01c27e4
Compare
Contributor
Author
|
(adjusted unit tests) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there are no tags available, then we cannot render an
<ul>element as this would result in invalid HTML / invalid accessibility state. Ref: https://www.w3.org/TR/wai-aria-1.2/#mustContainChecklist
3. to review, feature component)stable32)AI (if applicable)