fix(login-flow-v2): validate session user and clarify flow handling#59429
Draft
joshtrichards wants to merge 8 commits intomasterfrom
Draft
fix(login-flow-v2): validate session user and clarify flow handling#59429joshtrichards wants to merge 8 commits intomasterfrom
joshtrichards wants to merge 8 commits intomasterfrom
Conversation
… service Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
… clarity Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
…nstant 100% equivalent Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
added
feature: authentication
technical debt
Mostly just to accommodate internal exception string changes One new test for the new defense-in-depth UID check Signed-off-by: Josh <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clean up
LoginFlowV2Serviceto make the Login Flow v2 exchange easier to follow and safer to maintain.What changed
poll()flowDone()to ensure the session token user matches the provided user IDNo intended behavior changes beyond rejecting
flowDone()when the session token user does not match the provided user ID. This is intended as defense in depth; existing controller code paths already provide the expected user ID.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)