Skip to content

Job run history cleanup#60972

Open
Altahrim wants to merge 4 commits into
masterfrom
feat/clean_crashed_jobs
Open

Job run history cleanup#60972
Altahrim wants to merge 4 commits into
masterfrom
feat/clean_crashed_jobs

Conversation

@Altahrim
Copy link
Copy Markdown
Collaborator

@Altahrim Altahrim commented Jun 3, 2026

Summary

Clean table of past jobs

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@Altahrim Altahrim added this to the Nextcloud 35 milestone Jun 3, 2026
@Altahrim Altahrim self-assigned this Jun 3, 2026
@Altahrim Altahrim requested a review from a team as a code owner June 3, 2026 16:29
@Altahrim Altahrim requested review from ArtificialOwl, CarlSchwan, leftybournes and salmart-dev and removed request for a team June 3, 2026 16:29
@Altahrim Altahrim added 3. to review Waiting for reviews php Pull requests that update Php code labels Jun 3, 2026
@Altahrim Altahrim force-pushed the feat/clean_crashed_jobs branch from 3ac03ec to a2c1b10 Compare June 4, 2026 06:51
@Altahrim Altahrim changed the title Feat/clean crashed jobs Job run history cleanup Jun 4, 2026
@Altahrim Altahrim force-pushed the feat/clean_crashed_jobs branch 2 times, most recently from 3fac655 to f4ebe4f Compare June 4, 2026 07:00
@Altahrim
Copy link
Copy Markdown
Collaborator Author

Altahrim commented Jun 4, 2026

/backport to stable34 please

@Altahrim
Copy link
Copy Markdown
Collaborator Author

Altahrim commented Jun 4, 2026

Unrelated CI

@Altahrim Altahrim force-pushed the feat/clean_crashed_jobs branch 2 times, most recently from 9082daa to 1db38a7 Compare June 4, 2026 13:08
@Altahrim Altahrim requested a review from CarlSchwan June 4, 2026 13:08
@Altahrim Altahrim force-pushed the feat/clean_crashed_jobs branch from 1db38a7 to 6b0945c Compare June 4, 2026 13:33
Comment thread core/BackgroundJobs/CleanupBackgroundJobsJob.php
Comment thread core/BackgroundJobs/CleanupBackgroundJobsJob.php Outdated
@Altahrim Altahrim force-pushed the feat/clean_crashed_jobs branch 2 times, most recently from 012154c to bd26562 Compare June 4, 2026 18:31
Comment thread lib/public/Util.php Outdated
Comment on lines +280 to +284
/**
* Returns configured Server ID or use default fallback
* @since 34.0.1
*/
public static function getServerId() {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be in a dedicated IServerInfo service. Util is an historical monstruosity.

@Altahrim Altahrim force-pushed the feat/clean_crashed_jobs branch 3 times, most recently from d41f6db to 6a4c0e6 Compare June 8, 2026 12:57
Altahrim added 4 commits June 8, 2026 15:03
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@Altahrim Altahrim force-pushed the feat/clean_crashed_jobs branch from 6a4c0e6 to fad3f1e Compare June 8, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews backport-request php Pull requests that update Php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants