Defer nimsuggest instance init out of MCP initialize handler#408
Open
ZoomRmc wants to merge 1 commit into
Open
Defer nimsuggest instance init out of MCP initialize handler#408ZoomRmc wants to merge 1 commit into
ZoomRmc wants to merge 1 commit into
Conversation
The MCP `initialize` handler previously awaited `initNimsuggestInstances` before returning a response. This can be slow or hang (running `nimble dump`, starting nimsuggest processes). With some harnesses time-outs (30 second for OpenCode), a delayed initialize response causes the MCP connection to fail entirely, before any tool can be used. MCP protocol expects the server to respond to `initialize` promptly, then handle the `notifications/initialized` message. Heavy initialization should happen after the handshake. Fix: replace `await` with `asyncSpawn` so the initialize response is sent immediately and nimsuggest startup proceeds in the background.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MCP
initializehandler previously awaitedinitNimsuggestInstancesbefore returning a response. This can be slow or hang (runningnimble dump, starting nimsuggest processes). With some harnesses time-outs (30 second for OpenCode), a delayed initialize response causes the MCP connection to fail entirely, before any tool can be used.MCP protocol expects the server to respond to
initializepromptly, then handle thenotifications/initializedmessage. Heavy initialization should happen after the handshake.Fix: replace
awaitwithasyncSpawnso the initialize response is sent immediately and nimsuggest startup proceeds in the background.