Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #746 +/- ##
=======================================
Coverage 77.17% 77.17%
=======================================
Files 153 153
Lines 13771 13771
Branches 1114 1114
=======================================
Hits 10628 10628
Misses 3139 3139
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix loading of the Orama search database JSON by resolving it relative to the current page path (since orama-db.json lives at the site root, not alongside nested pages).
Changes:
- Update
useOramato compute the fetch URL viautils/url.mjs#relative()using the current pathname. - Thread page path information into the search UI (NavBar/SearchBox) to supply
useOramawith a pathname. - Bump package version to
1.3.1.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/generators/web/ui/hooks/useOrama.mjs |
Fetches orama-db.json via a computed relative URL based on pathname. |
src/generators/web/ui/components/SearchBox/index.jsx |
Changes SearchBox props to provide a path into useOrama. |
src/generators/web/ui/components/NavBar.jsx |
Attempts to pass path info down to SearchBox. |
src/generators/web/ui/components/Layout/index.jsx |
Attempts to pass metadata/path info into NavBar. |
package.json |
Version bump to 1.3.1. |
package-lock.json |
Lockfile version bump to 1.3.1. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
| File | Base | Head | Diff |
|---|---|---|---|
orama-db.json |
8.26 MB | 8.26 MB | -1.41 KB (-0.02%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Orama is located at the root, not at the same depth as a given page.