Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #747 +/- ##
==========================================
- Coverage 77.17% 77.08% -0.09%
==========================================
Files 153 153
Lines 13771 13749 -22
Branches 1114 1111 -3
==========================================
- Hits 10628 10599 -29
- Misses 3139 3146 +7
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
| File | Base | Head | Diff |
|---|---|---|---|
addons.html |
262.55 KB | 262.56 KB | +13.00 B (+0.00%) |
assert.html |
329.99 KB | 330.00 KB | +12.00 B (+0.00%) |
async_context.html |
187.56 KB | 187.58 KB | +12.00 B (+0.01%) |
async_hooks.html |
159.70 KB | 159.71 KB | +12.00 B (+0.01%) |
buffer.html |
905.71 KB | 905.72 KB | +12.00 B (+0.00%) |
child_process.html |
381.69 KB | 381.70 KB | +12.00 B (+0.00%) |
cli.html |
495.10 KB | 495.11 KB | +12.00 B (+0.00%) |
cluster.html |
196.29 KB | 196.30 KB | +12.00 B (+0.01%) |
console.html |
146.76 KB | 146.77 KB | +12.00 B (+0.01%) |
crypto.html |
1.09 MB | 1.09 MB | +12.00 B (+0.00%) |
debugger.html |
54.21 KB | 54.22 KB | +12.00 B (+0.02%) |
deprecations.html |
505.30 KB | 505.31 KB | +12.00 B (+0.00%) |
dgram.html |
194.36 KB | 194.37 KB | +12.00 B (+0.01%) |
diagnostics_channel.html |
303.41 KB | 303.42 KB | +12.00 B (+0.00%) |
dns.html |
295.80 KB | 295.81 KB | +12.00 B (+0.00%) |
documentation.html |
38.03 KB | 38.04 KB | +12.00 B (+0.03%) |
domain.html |
105.09 KB | 105.10 KB | +12.00 B (+0.01%) |
embedding.html |
59.42 KB | 59.43 KB | +12.00 B (+0.02%) |
environment_variables.html |
44.03 KB | 44.04 KB | +12.00 B (+0.03%) |
errors.html |
461.17 KB | 461.18 KB | +12.00 B (+0.00%) |
esm.html |
155.32 KB | 155.33 KB | +12.00 B (+0.01%) |
events.html |
455.26 KB | 455.27 KB | +12.00 B (+0.00%) |
fs.html |
1.43 MB | 1.43 MB | +12.00 B (+0.00%) |
globals.html |
230.36 KB | 230.37 KB | +12.00 B (+0.01%) |
http.html |
738.70 KB | 738.71 KB | +12.00 B (+0.00%) |
http2.html |
768.58 KB | 768.59 KB | +12.00 B (+0.00%) |
https.html |
150.34 KB | 150.35 KB | +12.00 B (+0.01%) |
index.html |
36.23 KB | 36.25 KB | +12.00 B (+0.03%) |
inspector.html |
171.37 KB | 171.38 KB | +12.00 B (+0.01%) |
intl.html |
58.13 KB | 58.14 KB | +12.00 B (+0.02%) |
module.html |
326.65 KB | 326.66 KB | +12.00 B (+0.00%) |
modules.html |
178.72 KB | 178.73 KB | +12.00 B (+0.01%) |
n-api.html |
807.24 KB | 807.25 KB | +12.00 B (+0.00%) |
net.html |
382.28 KB | 382.29 KB | +12.00 B (+0.00%) |
os.html |
142.72 KB | 142.73 KB | +12.00 B (+0.01%) |
packages.html |
154.64 KB | 154.65 KB | +12.00 B (+0.01%) |
path.html |
139.25 KB | 139.26 KB | +12.00 B (+0.01%) |
perf_hooks.html |
381.48 KB | 381.49 KB | +12.00 B (+0.00%) |
permissions.html |
55.13 KB | 55.14 KB | +12.00 B (+0.02%) |
process.html |
676.14 KB | 676.15 KB | +12.00 B (+0.00%) |
punycode.html |
63.18 KB | 63.19 KB | +12.00 B (+0.02%) |
querystring.html |
63.84 KB | 63.85 KB | +12.00 B (+0.02%) |
quic.html |
358.96 KB | 358.98 KB | +12.00 B (+0.00%) |
readline.html |
252.16 KB | 252.17 KB | +12.00 B (+0.00%) |
repl.html |
183.29 KB | 183.30 KB | +12.00 B (+0.01%) |
report.html |
175.91 KB | 175.92 KB | +12.00 B (+0.01%) |
single-executable-applications.html |
106.93 KB | 106.95 KB | +12.00 B (+0.01%) |
sqlite.html |
268.07 KB | 268.08 KB | +12.00 B (+0.00%) |
stream.html |
855.29 KB | 855.31 KB | +12.00 B (+0.00%) |
stream_iter.html |
309.02 KB | 309.03 KB | +12.00 B (+0.00%) |
string_decoder.html |
55.38 KB | 55.39 KB | +12.00 B (+0.02%) |
synopsis.html |
42.66 KB | 42.67 KB | +12.00 B (+0.03%) |
test.html |
766.71 KB | 766.72 KB | +12.00 B (+0.00%) |
timers.html |
133.49 KB | 133.51 KB | +12.00 B (+0.01%) |
tls.html |
373.78 KB | 373.79 KB | +12.00 B (+0.00%) |
tracing.html |
84.15 KB | 84.16 KB | +12.00 B (+0.01%) |
tty.html |
95.28 KB | 95.29 KB | +12.00 B (+0.01%) |
typescript.html |
53.46 KB | 53.47 KB | +12.00 B (+0.02%) |
url.html |
347.67 KB | 347.68 KB | +12.00 B (+0.00%) |
util.html |
691.88 KB | 691.89 KB | +12.00 B (+0.00%) |
v8.html |
321.08 KB | 321.09 KB | +12.00 B (+0.00%) |
vm.html |
370.79 KB | 370.80 KB | +12.00 B (+0.00%) |
wasi.html |
69.36 KB | 69.37 KB | +12.00 B (+0.02%) |
webcrypto.html |
521.99 KB | 522.00 KB | +12.00 B (+0.00%) |
webstreams.html |
355.72 KB | 355.74 KB | +12.00 B (+0.00%) |
worker_threads.html |
365.46 KB | 365.47 KB | +12.00 B (+0.00%) |
zlib.html |
290.23 KB | 290.24 KB | +12.00 B (+0.00%) |
zlib_iter.html |
88.05 KB | 88.06 KB | +12.00 B (+0.01%) |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
avivkeller
force-pushed
the
more-custom-web
branch
from
aafa31a to
11322b5
Compare
PR SummaryMedium Risk Overview Switches HTML rendering from ad-hoc Replaces Written by Cursor Bugbot for commit 620eaed. This will update automatically on new commits. Configure here. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Autofix Details
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Premature
{version}replacement breaks version selector URLscreateConfigSourcenow excludesversionbefore populatingpageURL, preserving{version}for per-entry replacement inbuildVersionEntries.
Or push these changes by commenting:
@cursor push 4e86c88af1
Preview (4e86c88af1)
diff --git a/src/generators/web/utils/config.mjs b/src/generators/web/utils/config.mjs
--- a/src/generators/web/utils/config.mjs
+++ b/src/generators/web/utils/config.mjs
@@ -76,7 +76,9 @@
const version = `v${config.version.version}`;
const editURL = populate(config.editURL, { ...config, version });
- const pageURL = populate(config.pageURL, config);
+ const configWithoutVersion = { ...config };
+ delete configWithoutVersion.version;
+ const pageURL = populate(config.pageURL, configWithoutVersion);
const exports = {
...Object.fromEntries(This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
…late()\n\nAvoid passing config.version (SemVer) to populate(config.pageURL, ...) so the {version} placeholder remains for buildVersionEntries to substitute per-version labels. This restores correct version selector URLs.
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
avivkeller
force-pushed
the
more-custom-web
branch
from
8996c2d to
620eaed
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| ...omitKeys( | ||
| config, | ||
| // These are keys that are large, and not needed by components, so we ignore them | ||
| ['changelog', 'index', 'imports', 'virtualImport'] |
There was a problem hiding this comment.
Typo in omit key: virtualImport vs virtualImports
Medium Severity
The omit list uses 'virtualImport' (singular), but the actual configuration key defined in defaultConfiguration and types.d.ts is 'virtualImports' (plural). This means the virtualImports object won't be excluded and will be serialized into the #theme/config virtual module as an unnecessary named export, increasing the client bundle size and exposing an internal config value that was intended to be filtered out.
This PR makes the
webgenerator even more customizable, for the learn content.It:
doc-kitconfigs to supply custom virtual modules, which will allow the learn contents' config to supply a reference tonavigation.jsonto populate the navigation the same as we do in core.doc-kittemplates to see more of theconfigobject, +path, meaning they can set their own canonical URLs usingpath, and whatnot.