Skip to content

test_runner: exclude ignored branches from lcov output#63156

Open
DevRajah wants to merge 1 commit intonodejs:mainfrom
DevRajah:fix-coverage-ignore-brda
Open

test_runner: exclude ignored branches from lcov output#63156
DevRajah wants to merge 1 commit intonodejs:mainfrom
DevRajah:fix-coverage-ignore-brda

Conversation

@DevRajah
Copy link
Copy Markdown

@DevRajah DevRajah commented May 6, 2026

Description

This updates the LCOV reporter to exclude BRDA entries for branches associated with ignored coverage lines.

Previously, ignored lines could be excluded from DA output while related branch entries were still emitted as BRDA, causing inconsistent LCOV output.

Fixes: #61586

Changes

  • Skip LCOV BRDA output for ignored branch lines
  • Recalculate BRF and BRH from emitted LCOV branch entries
  • Add a regression test for ignored branch behavior

Testing

node test/parallel/test-runner-coverage.js


Note: I was unable to complete a full Windows source build locally because the ClangCL compile ran out of memory, but the targeted test file was run with Node.js v24.14.0.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 6, 2026
@JakobJingleheimer
Copy link
Copy Markdown
Member

Duplicate of #61598

@JakobJingleheimer JakobJingleheimer marked this as a duplicate of #61598 May 6, 2026
@JakobJingleheimer JakobJingleheimer added the duplicate Issues and PRs that are duplicates of other issues or PRs. label May 6, 2026
@Gasila5

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate Issues and PRs that are duplicates of other issues or PRs. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_runner: node:coverage ignore comments exclude DA but leave BRDA in lcov output

4 participants