Skip to content

build: add build-ffi-tests as a requesite of test-ci-js#63165

Open
aduh95 wants to merge 1 commit intonodejs:mainfrom
aduh95:fix-ffi-test-ci-js
Open

build: add build-ffi-tests as a requesite of test-ci-js#63165
aduh95 wants to merge 1 commit intonodejs:mainfrom
aduh95:fix-ffi-test-ci-js

Conversation

@aduh95
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 commented May 7, 2026

Without it, I'm getting Missing FFI test fixture library when running test-js-ci on 26.1.0

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels May 7, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 force-pushed the fix-ffi-test-ci-js branch from 6920652 to 24244b5 Compare May 7, 2026 10:49
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.04%. Comparing base (b5da751) to head (24244b5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #63165   +/-   ##
=======================================
  Coverage   90.03%   90.04%           
=======================================
  Files         713      713           
  Lines      224510   224510           
  Branches    42438    42442    +4     
=======================================
+ Hits       202148   202153    +5     
+ Misses      14163    14160    -3     
+ Partials     8199     8197    -2     

see 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread Makefile
# This target should not use a native compiler at all
# Related CI job: node-test-commit-arm-fanned
test-ci-js: | clear-stalled ## Build and test JavaScript with building anything else.
test-ci-js: | clear-stalled build-ffi-tests ## Build and test JavaScript with building anything else.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fly by comment as I'm not at a computer at the moment to investigate in detail, but this does not feel correct. By definition test-ci-js should not require a native compiler -- those tests should be in test-ci-native. I can see a few lines above have test/ffi/.buildstamp as a requisite for test-ci-native, so my assumption would be that the ffi testsuite has been misclassified into CI_JS_SUITES instead of CI_NATIVE_SUITES.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants