Skip to content

fix(ui): empty space on search#8725

Open
avivkeller wants to merge 2 commits intomainfrom
fix/search-spacing
Open

fix(ui): empty space on search#8725
avivkeller wants to merge 2 commits intomainfrom
fix/search-spacing

Conversation

@avivkeller
Copy link
Member

@avivkeller avivkeller commented Mar 14, 2026

Fixes nodejs/doc-kit#670

Supersedes nodejs/doc-kit#678
Supersedes #8724

image

@avivkeller avivkeller requested a review from a team as a code owner March 14, 2026 20:48
Copilot AI review requested due to automatic review settings March 14, 2026 20:48
@vercel
Copy link

vercel bot commented Mar 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Ready Ready Preview Mar 14, 2026 8:52pm

Request Review

@github-actions
Copy link
Contributor

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website

Please review the changes when you have a chance. Thank you! 🙏

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts spacing in the search UI to reduce perceived empty space in the modal.

Changes:

  • Adds top padding to the search suggestions wrapper (pt-2).
  • Removes top padding from the search results wrapper (removes pt-3).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/ui-components/src/Common/Search/Suggestions/index.module.css Adds top padding to the suggestions container.
packages/ui-components/src/Common/Search/Results/index.module.css Removes top padding from the results container.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2026

📦 Build Size Comparison

Summary

Metric Value
Old Total Size 3.51 MB
New Total Size 3.51 MB
Delta 0 B (0.00%)

Changes

➕ Added Assets (1)
Name Size
.next/static/chunks/7778e8b3a082f32b.js 208.66 KB
➖ Removed Assets (1)
Name Size
.next/static/chunks/6192e9f57cb30b10.js 208.66 KB

@codecov
Copy link

codecov bot commented Mar 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.11%. Comparing base (c9a5b32) to head (5b33e56).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8725   +/-   ##
=======================================
  Coverage   75.11%   75.11%           
=======================================
  Files         104      104           
  Lines        9167     9167           
  Branches      315      315           
=======================================
  Hits         6886     6886           
  Misses       2279     2279           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikeesto
Copy link
Member

Screenshot 2026-03-15 at 12 01 05 pm

I must be missing something.. how do you not see the AI summary and suggestions?

@avivkeller
Copy link
Member Author

I must be missing something.. how do you not see the AI summary and suggestions?

Just a little DOM editing to mimic what this component looks like in doc-kit :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Empty Space in Search Modal

4 participants