feat(ui): show maintainers avatars#2055
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds a Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can use your project's `biome` configuration to improve the quality of JS/TS/CSS/JSON code reviews.Add a configuration file to your project to customize how CodeRabbit runs |
| <!-- Else fallback to initials (use svg to avoid underline styling) --> | ||
| <svg |
There was a problem hiding this comment.
I couldn't figure out how to remove the underline style if wrapped in an anchor tag, so I used an SVG here. Seems like you need block or inline-block in order to override it, but the parent div is a flex which seems to make anything under not work.
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 812011a8-23c3-45be-9c32-904fbc5a5f41
📒 Files selected for processing (2)
app/components/Package/Maintainers.vueapp/components/User/Avatar.vue
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
test/nuxt/a11y.spec.ts (1)
2854-2878: Consider adding accessibility tests forsize: 'xs'.All three UserAvatar tests now use
size: 'lg', but thexsvariant is also used in the codebase (e.g., in the maintainers section). Adding at least one test withsize: 'xs'would ensure both size variants are covered by accessibility audits.🧪 Suggested addition for xs size coverage
+ it('should have no accessibility violations with xs size', async () => { + const component = await mountSuspended(UserAvatar, { + props: { username: 'testuser', size: 'xs' }, + }) + const results = await runAxe(component) + expect(results.violations).toEqual([]) + }) + it('should have no accessibility violations', async () => { const component = await mountSuspended(UserAvatar, { props: { username: 'testuser', size: 'lg' },
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a55b1986-1c31-4e7f-b07f-4fec3efc6b35
📒 Files selected for processing (1)
test/nuxt/a11y.spec.ts
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
🔗 Linked issue
n/a
🧭 Context
I think it would be nice if the maintainers section showed the avatars.
It seems from #435 we're ok with displaying the avatar, but it was only implemented in the user/org pages.
📚 Description