-
-
Notifications
You must be signed in to change notification settings - Fork 335
feat: module replacements v3 #2068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gameroman
wants to merge
36
commits into
npmx-dev:main
Choose a base branch
from
gameroman:module-replacements-v3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+526
−251
Open
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
5ee3927
Update module-replacements dependency to 3.0.0-beta.0
gameroman 49dd770
Update [...pkg].get.ts
gameroman f276037
wip
gameroman e528c90
use a simpler approach
gameroman ad27978
revert
gameroman 59ac18c
wip
gameroman 6422b11
wip
gameroman 3ecebf0
Update use-replacement-dependencies.spec.ts
gameroman 7d4198b
Update use-replacement-dependencies.spec.ts
gameroman 1e94e2d
Update use-replacement-dependencies.spec.ts
gameroman 7ae1a63
Update use-replacement-dependencies.spec.ts
gameroman 8e8882b
Update Replacement.vue
gameroman 1c72e05
[autofix.ci] apply automated fixes
autofix-ci[bot] a36b4ce
Update Replacement.vue
gameroman 2464a08
Update Replacement.vue
gameroman d6f4b0b
update tests
gameroman 83102e3
Update use-compare-replacements.spec.ts
gameroman 363aa2a
Update use-compare-replacements.spec.ts
gameroman b30c0fd
Update use-compare-replacements.spec.ts
gameroman c1f52f2
Update use-compare-replacements.spec.ts
gameroman e346d83
Update a11y.spec.ts
gameroman f89546e
wip
gameroman 74eee66
Revert "wip"
gameroman a95b7a0
Update ReplacementSuggestion.vue
gameroman b60b234
Update ReplacementSuggestion.vue
gameroman 7207e50
Update en.json
gameroman 9e742ab
[autofix.ci] apply automated fixes
autofix-ci[bot] e365d7e
Update schema.json
gameroman 63417bf
create resolveReplacementUrl util
gameroman 93babd2
wip
gameroman 03584bd
don't render 'unknown'
gameroman 375bd0a
fix
gameroman 7ad1a05
Update Replacement.vue
gameroman bfd7ce1
Update schema.json
gameroman 2c69f4e
Update useCompareReplacements.ts
gameroman e16308c
Update useCompareReplacements.ts
gameroman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import type { KnownUrl } from 'module-replacements' | ||
|
|
||
| export function resolveReplacementUrl(url?: KnownUrl): string | null { | ||
| if (!url) return null | ||
| if (typeof url === 'string') return url | ||
|
|
||
| switch (url.type) { | ||
| case 'mdn': | ||
| return `https://developer.mozilla.org/en-US/docs/${url.id}` | ||
| case 'node': | ||
| return `https://nodejs.org/${url.id}` | ||
| case 'e18e': | ||
| return `https://e18e.dev/docs/replacements/${url.id}` | ||
| default: | ||
| return null | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.