feat: update downloads title desc and translate zh-CN/zh-TW#2695
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR introduces version-aware download accessibility labels across the package versions page, updates the i18n schema to support version-specific label templates, normalises English UI capitalisation globally, expands translations in Simplified and Traditional Chinese, and scaffolds placeholder keys for other locales to support future translator work. ChangesDownloads Versioning & Localization
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/pages/package/`[[org]]/[name]/versions.vue:
- Around line 549-555: The header rows are passing the internal group key into
getDownloadsAriaLabel which can surface an internal identifier; update the calls
that build the header aria/title text to pass the user-facing label instead (use
item.label or an explicit display string) rather than item.groupKey—specifically
change the getDownloadsAriaLabel invocations for grouped header rows
(references: getDownloadsAriaLabel, item.groupKey, item.label,
groupDownloadsMap.get(...)) so the tooltip/aria text shows the displayed group
label while still using groupDownloadsMap.get(item.groupKey)! to fetch counts.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: cb71e376-6708-4870-adba-ceeb68208100
📒 Files selected for processing (18)
app/pages/package/[[org]]/[name]/versions.vuei18n/locales/cs-CZ.jsoni18n/locales/de.jsoni18n/locales/en.jsoni18n/locales/es.jsoni18n/locales/fr-FR.jsoni18n/locales/id-ID.jsoni18n/locales/nb-NO.jsoni18n/locales/nl.jsoni18n/locales/pt-BR.jsoni18n/locales/pt-PT.jsoni18n/locales/ru-RU.jsoni18n/locales/sr-Latn-RS.jsoni18n/locales/uk-UA.jsoni18n/locales/vi-VN.jsoni18n/locales/zh-CN.jsoni18n/locales/zh-TW.jsoni18n/schema.json
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@i18n/locales/en.json`:
- Around line 1676-1677: The brand object in the locale JSON has duplicated
"heading" keys which overwrote the intended value and breaks the schema
expecting both "title" and "heading"; locate the duplicate keys in the brand
object and rename the first "heading": "Brand" entry to "title": "Brand" so the
object contains both "title" and "heading" properties (preserving the second
"heading": "brand") to restore schema compliance.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: e5bb1aae-711c-482c-9155-501c244306c2
📒 Files selected for processing (5)
app/pages/package/[[org]]/[name]/versions.vuei18n/locales/en.jsoni18n/locales/zh-CN.jsoni18n/locales/zh-TW.jsoni18n/schema.json
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
btea
force-pushed
the
feat/update-download-desc-and-zh-translations
branch
from
e53bed4 to
5b680fc
Compare
|
Of course, the conflict has been resolved. Below is a comparison of the two versions before and after the modification.
|
2 participants
🔗 Linked issue
🧭 Context
We've made the download count descriptions clearer and more accurate, and updated the relevant Chinese translations.
📚 Description