fix(video): Dolby Vision crash, 50% faster transcode, fps/bitrate/GPS fixes#399
Open
HuuNguyen312 wants to merge 4 commits into
Open
fix(video): Dolby Vision crash, 50% faster transcode, fps/bitrate/GPS fixes#399HuuNguyen312 wants to merge 4 commits into
HuuNguyen312 wants to merge 4 commits into
Conversation
iPhone HDR .MOV uses video/dolby-vision mime which has no
standalone Android decoder, so createDecoderByType throws
"Failed to initialize video/dolby-vision". DV profiles 8.x
carry an HEVC base layer, so remap mime to video/hevc before
configuring the decoder. Reject profile 5 (0x20) explicitly
since it has no HEVC fallback.
Perf, bundled to land with the codec rework:
- Pick HW AVC encoder via MediaCodecList(ALL_CODECS), blacklist
c2.qti.avc.encoder (corrupt MP4 on Mac/iOS).
- Feed decoder until input slots drain instead of one sample
per loop; unblocks parallel decode-render-encode.
- Drop decoded frames whose PTS precedes the next target slot
when source fps exceeds output fps.
- Encoder: VBR + KEY_PRIORITY=0 + KEY_OPERATING_RATE=MAX to
unthrottle HW codec scheduling.
- Route SurfaceTexture onFrameAvailable to a dedicated
HandlerThread so awaitNewImage stops contending with the
main/JS thread.
- Skip StreamableVideo rewrite unless caller passed a
streamableFile; halves disk I/O for chat uploads.
Android: extract METADATA_KEY_LOCATION and write an Apple-style "©xyz" udta atom into the muxed MP4 so geotags survive transcoding. iOS: forward asset.metadata plus every available metadata format to the AVAssetExportSession so location, creation date, and other tags are retained in the exported file. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- fps: derive from frame_count/duration when CAPTURE_FRAMERATE absent. Cap 30→60. Drop-gate only when source>target, anchor to ideal grid. - bitrate: WhatsApp envelope (~1.5 Mbps @ 720p). Android+iOS sync. - GPS: LocationExtractor walks MP4 — ©xyz, loci, iTunes meta/keys+ilst, SEF trailer regex. Writer ©xyz moved to LocationBox class. - teardown: runCatching every dispose step. join() OutputSurface thread after quitSafely to avoid SIGABRT on stale pthread_t. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
HuuNguyen312
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bug (#398) — Dolby Vision crash on .MOV from iPhone:
createDecoderByType("video/dolby-vision") throws on Android — no standalone DV decoder. DV profile 8.x has HEVC base layer, so remap mime → video/hevc. Reject profile 5 (0x20) explicitly (no HEVC fallback).
Perf (#384) — ~50% faster transcode:
fps detection:
Bitrate:
GPS preservation:
Stability:
Changelog
[ANDROID] [FIXED] Dolby Vision .MOV no longer crashes (#398)
[ANDROID] [CHANGED] Transcode pipeline ~50% faster (#384)
[ANDROID] [FIXED] Source fps derived from frame count when CAPTURE_FRAMERATE absent
[ANDROID] [FIXED] GPS metadata preserved via raw MP4 box walker + Samsung SEF scan
[iOS] [FIXED] fps cap raised to 60; bitrate bands halved; source metadata forwarded
[ANDROID] [FIXED] Codec teardown wrapped in runCatching; OutputSurface thread joined
Test Plan