[ADD] Inventory: USPS delivery method#17878
Closed
erjer-odoo wants to merge 1 commit into
Closed
Conversation
Collaborator
|
|
Contributor
Author
|
@huisit This PR is ready for review when you have a moment. A note about points: This is a supplementary PR to one I've created for 17.0. The UI language changed, so the 18.0 documentation also had to be "updated" to include the new language. While we are adding this new documentation from this branch forward, it technically counts as a doc update, not a full [ADD], so I've assiged 2 points to it. |
huisit
approved these changes
May 14, 2026
Contributor
huisit
left a comment
huisit
left a comment
There was a problem hiding this comment.
@erjer-odoo this is an excellent delivery method article! A standard to hold the existing ones to IMO :)
I've carried over Megan's suggestions as applied in the 17.0 PR, and provided some wording alternatives. The main things I'd suggest are:
- Begin list descriptions with imperative/present: You already did this for the latter half, consider applying to the first half for consistency/conciseness/instructing based on the field type, i.e. drop-down vs. input.
- Add links for context:
- Link CRID in General information to Create a developer app, to explain where to find the input.
- Link to developer mode doc in last section, for instructions to turn on.
- Add custom anchors: both for CRID and potential/future use.
And just a nice-to-have, but if you apply any of my suggestions here, it would be nice to apply them to 17.0 too so they match. All trivial so approved, take whatever resonates!
erjer-odoo
force-pushed
the
18.0-inventory-usps-delivery-erjer
branch
from
a4b2656 to
e3ecfcb
Compare
Contributor
Author
|
@Felicious This PR is ready for final review when you have a moment. Thank you! |
Felicious
approved these changes
May 18, 2026
Co-authored-by: Rex <11528309+huisit@users.noreply.github.com> Co-authored-by: Felicious <feku@odoo.com>
erjer-odoo
force-pushed
the
18.0-inventory-usps-delivery-erjer
branch
from
e3ecfcb to
99d1e42
Compare
Contributor
Author
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
May 18, 2026
closes #17878 Signed-off-by: Erin Jerison (erjer) <erjer@odoo.com> Co-authored-by: Rex <11528309+huisit@users.noreply.github.com> Co-authored-by: Felicious <feku@odoo.com>
This was referenced May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task card.
Adding new documentation around the USPS integration.
This 18.0 PR can be FWP up to master.