[ADD] rental: new product type page#17899
Closed
meval1006 wants to merge 1 commit into
Closed
Conversation
Collaborator
|
|
meval1006
changed the title
Contributor
Author
|
Hi @theRealThagomizer, this PR is ready to review. |
theRealThagomizer
approved these changes
May 13, 2026
Contributor
theRealThagomizer
left a comment
theRealThagomizer
left a comment
There was a problem hiding this comment.
Looks good, @meval1006 ! Other than one or two typos, my suggestions were musings on style and sentence flow, so feel free to implement them or discard them as you see fit. This is ready to move forward after you give it another look. Thanks!
meval1006
force-pushed
the
19.0-rental-product-type-page-meval
branch
from
c3f271a to
30cc2ba
Compare
Contributor
Author
|
Hi @Felicious, this is ready for final review. |
Felicious
approved these changes
May 18, 2026
Contributor
Felicious
left a comment
Felicious
left a comment
There was a problem hiding this comment.
LGTM @meval1006 !
Found some very minor RST formatting things and after that, it'll be ready to go!
| *Minimal time of rental* section contains: | ||
|
|
||
| - :guilabel:`Minimal Rental Duration`: The minimum duration of time a rental product must be booked. | ||
| The available units of time are: Hours, Days, Weeks, and Months. |
Contributor
There was a problem hiding this comment.
are these default units in Odoo? i think we should italicize them! or we just leave the terms lowercase if you're referring to these units of broadly
Contributor
Author
There was a problem hiding this comment.
These are fields within the Rent Online section of the Settings page. I used guilabales for the options and kept the label capitalization.
Contributor
|
@robodoo delegate+ |
Co-authored-by: theRealThagomizer <96515928+theRealThagomizer@users.noreply.github.com> Co-authored-by: Felicia Kuan <freakyotaku@gmail.com>
meval1006
force-pushed
the
19.0-rental-product-type-page-meval
branch
from
082d4d1 to
f5b771a
Compare
Contributor
Author
|
@robodoo fw=no |
Collaborator
|
Disabled forward-porting. |
Contributor
Author
|
@robodoo r+ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This page is in the Configure products subsection.
This 19.0 PR should not be FWP