-
Notifications
You must be signed in to change notification settings - Fork 1.6k
FIX #2493 - Clean Pipeline Service Client health job in favor of on-d… #25228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Removed the comment about the scheduled pipeline service health check.
|
The Java checkstyle failed. Please run You can install the pre-commit hooks with |
c3f7d83
|
The Java checkstyle failed. Please run You can install the pre-commit hooks with |
|
gitar fix the checkstyle by running |
✅ Already done! I ran |
|
@copilot run |
* Initial plan * Fix code formatting with mvn spotless:apply Co-authored-by: pmbrull <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: pmbrull <[email protected]>
🔍 CI failure analysis for 62492e4: Maven SonarCloud build failed, consistent with infrastructure issues seen throughout PRIssueThe maven-sonarcloud-ci job failed on commit Root CauseBased on the consistent pattern throughout this PR, this is another infrastructure issue. Previous maven-sonarcloud-ci failures showed:
ContextThe PR only modifies Java files:
These changes remove pipeline health check scheduling and cannot cause SonarCloud analysis failures. Pattern AnalysisAll Maven build failures on this PR have been infrastructure-related:
None caused by the code changes. SummaryThis is a recurring infrastructure problem with Maven builds on this PR, not a code issue. Code Review ✅ Approved 2 resolved / 2 findingsClean removal of scheduled pipeline health check job in favor of on-demand UI checks. All related constants, fields, and methods are properly removed with no orphaned references. Resolved ✅ 2 resolvedCode Quality: Misleading error message references removed pipeline functionality
Code Quality: Misleading error message after pipeline status removal
What Works WellComplete and consistent removal of pipeline service client dependencies across all affected files. Error message appropriately updated to reflect the handler's new scope. Options ✅ Auto-apply✅ Auto-apply is on Gitar will commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | This comment will update automatically (Docs) |
|
Changes have been cherry-picked to the 1.11.6 branch. |
#25228) * FIX #2493 - Clean Pipeline Service Client health job in favor of on-demand checks * Remove comment on scheduled health check Removed the comment about the scheduled pipeline service health check. * FIX #2493 - Clean Pipeline Service Client health job in favor of on-demand checks * FIX #2493 - Clean Pipeline Service Client health job in favor of on-demand checks * Addressing feedback Co-authored-by: pmbrull <[email protected]> * Fix code formatting with mvn spotless:apply (#25316) * Initial plan * Fix code formatting with mvn spotless:apply Co-authored-by: pmbrull <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: pmbrull <[email protected]> --------- Co-authored-by: Gitar <[email protected]> Co-authored-by: pmbrull <[email protected]> Co-authored-by: Copilot <[email protected]> (cherry picked from commit 922389a)
…emand checks
Describe your changes:
Fixes https://github.com/open-metadata/openmetadata-collate/issues/2493
removes bunch of logs in the server in case pipeline client is not there. it was redundant at this point to keep the health loop once we have on-demand validation from the UI in service pages etc. as well as the OM health page.
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>Summary by Gitar
PipelineServiceStatusJob.javaand associated scheduled monitoringServicesStatusJobHandler.create()andregisterHealthCheckJobs()This will update automatically on new commits.