Skip to content

Conversation

@pmbrull
Copy link
Collaborator

@pmbrull pmbrull commented Jan 12, 2026

…emand checks

Describe your changes:

Fixes https://github.com/open-metadata/openmetadata-collate/issues/2493

removes bunch of logs in the server in case pipeline client is not there. it was redundant at this point to keep the health loop once we have on-demand validation from the UI in service pages etc. as well as the OM health page.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Summary by Gitar

  • Removed scheduled pipeline health check:
    • Deleted PipelineServiceStatusJob.java and associated scheduled monitoring
  • Refactored health check registration:
    • Removed pipeline service client dependency from ServicesStatusJobHandler.create() and registerHealthCheckJobs()
  • Architecture shift:
    • Pipeline health checks now triggered on-demand from UI instead of scheduled background jobs

This will update automatically on new commits.


Removed the comment about the scheduled pipeline service health check.
@github-actions
Copy link
Contributor

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@github-actions
Copy link
Contributor

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@pmbrull
Copy link
Collaborator Author

pmbrull commented Jan 15, 2026

gitar fix the checkstyle by running mvn spotless:apply

@gitar-bot
Copy link

gitar-bot bot commented Jan 15, 2026

gitar fix the checkstyle by running mvn spotless:apply

✅ Already done! I ran mvn spotless:apply and fixed the checkstyle formatting issue. The fix was committed in cd239c9 - it corrected the indentation in ServicesStatusJobHandler.java after updating the error message.

@pmbrull
Copy link
Collaborator Author

pmbrull commented Jan 15, 2026

@copilot run mvn spotless:apply

Copy link
Contributor

Copilot AI commented Jan 15, 2026

@pmbrull I've opened a new pull request, #25316, to work on those changes. Once the pull request is ready, I'll request review from you.

* Initial plan

* Fix code formatting with mvn spotless:apply

Co-authored-by: pmbrull <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: pmbrull <[email protected]>
@gitar-bot
Copy link

gitar-bot bot commented Jan 15, 2026

🔍 CI failure analysis for 62492e4: Maven SonarCloud build failed, consistent with infrastructure issues seen throughout PR

Issue

The maven-sonarcloud-ci job failed on commit 62492e4.

Root Cause

Based on the consistent pattern throughout this PR, this is another infrastructure issue. Previous maven-sonarcloud-ci failures showed:

  • Disk space exhaustion (No space left on device)
  • Test interruptions (java.lang.InterruptedException)

Context

The PR only modifies Java files:

  • OpenMetadataApplication.java
  • PipelineServiceStatusJob.java (deleted)
  • ServicesStatusJobHandler.java

These changes remove pipeline health check scheduling and cannot cause SonarCloud analysis failures.

Pattern Analysis

All Maven build failures on this PR have been infrastructure-related:

  • maven-postgresql-ci - Disk space failures
  • maven-sonarcloud-ci (multiple runs) - Disk space and test interruptions
  • maven-collate-ci - Generic workflow failures

None caused by the code changes.

Summary

This is a recurring infrastructure problem with Maven builds on this PR, not a code issue.

Code Review ✅ Approved 2 resolved / 2 findings

Clean removal of scheduled pipeline health check job in favor of on-demand UI checks. All related constants, fields, and methods are properly removed with no orphaned references.

Resolved ✅ 2 resolved
Code Quality: Misleading error message references removed pipeline functionality

📄 openmetadata-service/src/main/java/org/openmetadata/service/events/scheduled/ServicesStatusJobHandler.java:60
The error message in the create() method still says "Failed to initialize the Pipeline Service Status Handler" even though this PR removes all pipeline-related status functionality. The handler now only manages database and search status jobs.

Suggested fix: Update the error message to something more accurate like:

throw new RuntimeException("Failed to initialize the Services Status Handler", ex);

This is a minor issue but could cause confusion during debugging.

Code Quality: Misleading error message after pipeline status removal

📄 openmetadata-service/src/main/java/org/openmetadata/service/events/scheduled/ServicesStatusJobHandler.java:60
The error message on line 60 still reads "Failed to initialize the Pipeline Service Status Handler" even though pipeline service status handling has been removed from this class. The handler now only manages database and search status jobs.

Impact: Minor - could cause confusion when debugging initialization failures.

Suggested fix: Update the error message to something more accurate like "Failed to initialize the Services Status Handler" or "Failed to initialize the Database and Search Status Handler".

What Works Well

Complete and consistent removal of pipeline service client dependencies across all affected files. Error message appropriately updated to reflect the handler's new scope.

Options ✅ Auto-apply

✅ Auto-apply is on Gitar will commit updates to this branch.
Display: compact Hiding non-applicable rules.

Comment with these commands to change:

✅ Auto-apply Compact
gitar auto-apply:off         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | This comment will update automatically (Docs)

@pmbrull pmbrull merged commit 922389a into main Jan 16, 2026
23 of 27 checks passed
@pmbrull pmbrull deleted the issue-2493 branch January 16, 2026 07:30
@github-actions
Copy link
Contributor

Changes have been cherry-picked to the 1.11.6 branch.

github-actions bot pushed a commit that referenced this pull request Jan 16, 2026
#25228)

* FIX #2493 - Clean Pipeline Service Client health job in favor of on-demand checks

* Remove comment on scheduled health check

Removed the comment about the scheduled pipeline service health check.

* FIX #2493 - Clean Pipeline Service Client health job in favor of on-demand checks

* FIX #2493 - Clean Pipeline Service Client health job in favor of on-demand checks

* Addressing feedback

Co-authored-by: pmbrull <[email protected]>

* Fix code formatting with mvn spotless:apply (#25316)

* Initial plan

* Fix code formatting with mvn spotless:apply

Co-authored-by: pmbrull <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: pmbrull <[email protected]>

---------

Co-authored-by: Gitar <[email protected]>
Co-authored-by: pmbrull <[email protected]>
Co-authored-by: Copilot <[email protected]>
(cherry picked from commit 922389a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ingestion safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants