Implement db.query.summary for SqlClientAttributesExtractor
#15548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
db-query-summary-sql
branch
5 times, most recently
from
f299e7c to
c5970ae
Compare
trask
commented
Dec 6, 2025
Comment on lines
155
to
157
| equalTo( | ||
| DbAttributes.DB_QUERY_SUMMARY, | ||
| emitStableDatabaseSemconv() ? "CALL" : null)), |
Member
Author
There was a problem hiding this comment.
should this be CALL NEXT VALUE?
Contributor
There was a problem hiding this comment.
I think it would be better to call it CALL Customer_SEQ or maybe CALL NEXT VALUE FOR Customer_SEQ. Having the summary contain the sequence name feels more informative. The sample summaries in the spec also contain the table names.
31 tasks
trask
force-pushed
the
db-query-summary-sql
branch
3 times, most recently
from
e761302 to
69592b0
Compare
trask
force-pushed
the
db-query-summary-sql
branch
2 times, most recently
from
ef34cbd to
a93e84c
Compare
trask
force-pushed
the
db-query-summary-sql
branch
2 times, most recently
from
5e17083 to
ca07ae2
Compare
github-actions
bot
added
the
test native
trask
force-pushed
the
db-query-summary-sql
branch
14 times, most recently
from
f59b245 to
ec8f197
Compare
trask
changed the title
db.query.summary for SqlClientAttributesExtractor
trask
force-pushed
the
db-query-summary-sql
branch
10 times, most recently
from
160b838 to
09ad46d
Compare
trask
force-pushed
the
db-query-summary-sql
branch
from
2fb7a05 to
3c6ae79
Compare
This was referenced Jan 17, 2026
Copilot AI
added a commit
that referenced
this pull request
Jan 17, 2026
Cherry-picked non-test files from PR #15548
Copilot AI
added a commit
that referenced
this pull request
Jan 17, 2026
Cherry-picked non-test files from PR #15548
23 tasks
Copilot AI
added a commit
that referenced
this pull request
Jan 17, 2026
- Updated imports to use emitStableDatabaseSemconv() and DB_QUERY_SUMMARY - Added AttributeAssertion and ArrayList imports - Added attributeAssertions() helper method for reusable attribute checks - Updated span names to conditionally use table name vs db name based on stable semconv - Replaced inline attribute assertions with calls to helper method - Updated error test to use new helper method with dynamic error attributes Co-authored-by: trask <[email protected]>
This was referenced Jan 17, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.