Spring config type safe coercion #15784
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
test native
trask
reviewed
Jan 7, 2026
| .isEqualTo("string_value"); | ||
|
|
||
| assertThat(config.getBoolean("bool_key")).isTrue(); | ||
| assertThat(config.getBoolean("bool_key_with_env")).isNull(); |
Member
There was a problem hiding this comment.
with otel declarative config this would be isTrue(), I think it will be confusing if that doesn't work
Member
Author
There was a problem hiding this comment.
yes, that's possible - neither PR is perfect in terms of UX.
I think we have to start with one and see how user like it.
- From my own experience, the spring style override is more common, which still works
- non-string properties are also quite rare
Member
There was a problem hiding this comment.
the spring style override
what is the spring style override?
Member
Author
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
Thanks. I'm coming around to doing the runtime coercion for spring that you originally proposed...
Member
Author
There was a problem hiding this comment.
OK - feel free to merge 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative for #15775 that limits type ceorcion to environment variables.