Add db.query.summary support to Cassandra instrumentations #15919

Copilot · 2026-01-18T23:33:24Z

Original prompt

Implementation Guide: Adding db.query.summary Support to Cassandra Instrumentations

Quick Start

This guide shows how to add db.query.summary support to Cassandra instrumentations (versions 3.0, 4.0, and 4.4).

Prerequisites

CRITICAL: You must cherry-pick changes from PR #15896. This PR adds the SqlStatementInfo.getQuerySummary() method, the ExtractQuerySummaryMarker interface, and span name extraction for SqlClientAttributesGetter.
git fetch origin pull/15896/head
git cherry-pick FETCH_HEAD
Implementation Steps

1. Update CassandraSqlAttributesGetter to additionally implement the marker interface ExtractQuerySummaryMarker

2. Update Tests

Update test assertions to account for the new behavior brought by the marker interface under the stable semconv flag.

Important: make minimal changes, do not make any structural changes.

Where needed, update

hasSpanName(...)

equalTo(maybeStable(DB_OPERATION), ...) to equalTo(maybeStable(DB_OPERATION), emitStableDatabaseSemconv() ? null : ...)

equalTo(maybeStable(DB_CASSANDRA_TABLE), ...) to equalTo(maybeStable(DB_CASSANDRA_TABLE), emitStableDatabaseSemconv() ? null : ...)

Where needed, add
equalTo(DB_QUERY_SUMMARY, emitStableDatabaseSemconv() ? ... : null)
(immediately after DB_STATEMENT assertion).

Make other similar changes to test assertions if needed to make tests pass.

Always static import emitStableDatabaseSemconv and DB_QUERY_SUMMARY.

Verification

Run tests for each Cassandra version:
./gradlew :instrumentation:cassandra:cassandra-<version>:javaagent:test
./gradlew :instrumentation:cassandra:cassandra-<version>:javaagent:testStableSemconv

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: trask <[email protected]>

…ents Co-authored-by: trask <[email protected]>

trask · 2026-01-19T01:12:07Z

@copilot fix tests

./gradlew :instrumentation:cassandra:cassandra-3.0:javaagent:test :instrumentation:cassandra:cassandra-3.0:javaagent:testStableSemconv :instrumentation:cassandra:cassandra-4.0:javaagent:test :instrumentation:cassandra:cassandra-4.0:javaagent:testStableSemconv :instrumentation:cassandra:cassandra-4.4:javaagent:test :instrumentation:cassandra:cassandra-4.4:javaagent:testStableSemconv :instrumentation:cassandra:cassandra-4.4:library:test :instrumentation:cassandra:cassandra-4.4:library:testStableSemconv

Co-authored-by: trask <[email protected]>

Copilot · 2026-01-19T01:36:47Z

@copilot fix tests

...

Fixed in cddb2d0. The issue was that when ExtractQuerySummaryMarker is implemented, the metrics include db.query.summary instead of db.operation.name in stable semconv mode. Updated the metrics tests to expect the correct attribute.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

develocity.opentelemetry.io
- Triggering command: /usr/lib/jvm/temurin-21-jdk-amd64/bin/java /usr/lib/jvm/temurin-21-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -XX:MaxMetaspaceSize=512m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant (dns block)
scans-in.gradle.com
- Triggering command: /usr/lib/jvm/temurin-21-jdk-amd64/bin/java /usr/lib/jvm/temurin-21-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -XX:MaxMetaspaceSize=512m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

trask · 2026-01-19T01:58:56Z

instrumentation/cassandra/cassandra-3.0/javaagent/src/test/java/CassandraClientTest.java

        "io.opentelemetry.cassandra-3.0",
        DB_SYSTEM_NAME,
-        DB_OPERATION_NAME,
+        emitStableDatabaseSemconv() ? DB_QUERY_SUMMARY : DB_OPERATION_NAME,


@copilot assertDurationMetric method already has an internal check and only applies to emitStableDatabaseSemconv, so this can be simplified to just DB_QUERY_SUMMARY

make this change in instrumentation/cassandra/cassandra-4-common/testing/src/main/java/io/opentelemetry/cassandra/v4/common/AbstractCassandraTest.java too

Simplified in c201605. Removed the conditional and unused DB_OPERATION_NAME imports from both files since assertDurationMetric only runs when emitStableDatabaseSemconv() is true.

Co-authored-by: trask <[email protected]>

Copilot · 2026-01-19T02:12:50Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

develocity.opentelemetry.io
- Triggering command: /usr/lib/jvm/temurin-21-jdk-amd64/bin/java /usr/lib/jvm/temurin-21-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -XX:MaxMetaspaceSize=512m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant (dns block)
scans-in.gradle.com
- Triggering command: /usr/lib/jvm/temurin-21-jdk-amd64/bin/java /usr/lib/jvm/temurin-21-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -XX:MaxMetaspaceSize=512m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

trask · 2026-01-19T04:36:30Z

@copilot run ./gradlew spotlessApply

Co-authored-by: trask <[email protected]>

Copilot · 2026-01-19T04:43:49Z

@copilot run ./gradlew spotlessApply

Done in 7ec9657. Spotless formatting has been applied to split long lines in the test files.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

develocity.opentelemetry.io
- Triggering command: /usr/lib/jvm/temurin-21-jdk-amd64/bin/java /usr/lib/jvm/temurin-21-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -XX:MaxMetaspaceSize=512m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant (dns block)
scans-in.gradle.com
- Triggering command: /usr/lib/jvm/temurin-21-jdk-amd64/bin/java /usr/lib/jvm/temurin-21-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -XX:MaxMetaspaceSize=512m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Initial plan

4810a6b

Copilot AI assigned Copilot and trask Jan 18, 2026

Copilot started work on behalf of trask January 18, 2026 23:33 View session

trask and others added 3 commits January 18, 2026 23:36

Add query summarization to sql sanitization

11a14bc

Add db.query.summary support to Cassandra instrumentations

c683ad9

Co-authored-by: trask <[email protected]>

Fix Cassandra 3.0 tests to not expect db.query.summary for USE statem…

8d68193

…ents Co-authored-by: trask <[email protected]>

Copilot AI changed the title ~~[WIP] Add db.query.summary support to Cassandra instrumentations~~ Add db.query.summary support to Cassandra instrumentations Jan 19, 2026

Copilot AI requested a review from trask January 19, 2026 00:21

Copilot finished work on behalf of trask January 19, 2026 00:21

Copilot started work on behalf of trask January 19, 2026 01:12 View session

Fix metrics tests to use db.query.summary instead of db.operation.name

cddb2d0

Co-authored-by: trask <[email protected]>

Copilot finished work on behalf of trask January 19, 2026 01:37

trask reviewed Jan 19, 2026

View reviewed changes

Copilot started work on behalf of trask January 19, 2026 01:59 View session

Simplify metrics test to use DB_QUERY_SUMMARY directly

c201605

Co-authored-by: trask <[email protected]>

Copilot AI requested a review from trask January 19, 2026 02:12

Copilot finished work on behalf of trask January 19, 2026 02:12

Copilot started work on behalf of trask January 19, 2026 04:36 View session

Apply spotless formatting

7ec9657

Co-authored-by: trask <[email protected]>

Copilot finished work on behalf of trask January 19, 2026 04:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add db.query.summary support to Cassandra instrumentations #15919

Add db.query.summary support to Cassandra instrumentations #15919

Copilot AI commented Jan 18, 2026 •

edited

Loading

Uh oh!

trask commented Jan 19, 2026

Uh oh!

Copilot AI commented Jan 19, 2026 •

edited

Loading

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

trask Jan 19, 2026

Uh oh!

Copilot AI Jan 19, 2026

Uh oh!

Copilot AI commented Jan 19, 2026

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

trask commented Jan 19, 2026

Uh oh!

Copilot AI commented Jan 19, 2026 •

edited

Loading

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Add db.query.summary support to Cassandra instrumentations #15919

Are you sure you want to change the base?

Add db.query.summary support to Cassandra instrumentations #15919

Conversation

Copilot AI commented Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Implementation Guide: Adding db.query.summary Support to Cassandra Instrumentations

Quick Start

Prerequisites

Implementation Steps

1. Update CassandraSqlAttributesGetter to additionally implement the marker interface ExtractQuerySummaryMarker

2. Update Tests

Verification

Uh oh!

trask commented Jan 19, 2026

Uh oh!

Copilot AI commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

trask Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Jan 19, 2026

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

trask commented Jan 19, 2026

Uh oh!

Copilot AI commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Jan 18, 2026 •

edited

Loading

Implementation Guide: Adding `db.query.summary` Support to Cassandra Instrumentations

Copilot AI commented Jan 19, 2026 •

edited

Loading

Copilot AI commented Jan 19, 2026 •

edited

Loading