Add HTTPX hook access to request and response objects#4564
Open
Harshal96 wants to merge 3 commits into
Open
Conversation
Assisted-by: OpenAI Codex
Member
|
Thanks for the PR! Just a heads-up: we no longer update Please add the appropriate changelog fragment for this change instead of editing |
Assisted-by: OpenAI Codex
Author
|
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add access to the original
httpx.Requestandhttpx.Responseobjects from HTTPX request and response hook info while preserving the existing tuple fields. This lets hooks read request content and callresponse.response.read()orresponse.response.aread()so HTTPX caches response bodies for later application use.Fixes #2556
Type of change
How Has This Been Tested?
uv run --no-sync --with tox tox -e py312-test-instrumentation-httpx-1-wrapt2uv run --no-sync --with tox tox -e py312-test-instrumentation-httpx-0-wrapt2uv run --no-sync --with tox tox -e lint-instrumentation-httpxuv run --no-sync --with pre-commit pre-commit run ruff --files instrumentation/opentelemetry-instrumentation-httpx/src/opentelemetry/instrumentation/httpx/__init__.py instrumentation/opentelemetry-instrumentation-httpx/tests/test_httpx_integration.py instrumentation/opentelemetry-instrumentation-httpx/README.rstuv run --no-sync --with pre-commit pre-commit run ruff-format --files instrumentation/opentelemetry-instrumentation-httpx/src/opentelemetry/instrumentation/httpx/__init__.py instrumentation/opentelemetry-instrumentation-httpx/tests/test_httpx_integration.pyuv run --no-sync --with pre-commit pre-commit run rstcheck --files instrumentation/opentelemetry-instrumentation-httpx/README.rstDoes This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.