fix: #2873 preserve computer driver compatibility for modifier keys#2877
Open
fix: #2873 preserve computer driver compatibility for modifier keys#2877
Conversation
seratch
force-pushed
the
fix/computer-modifier-keys-compat
branch
from
1f41c59 to
a76e7db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves #2873.
This pull request fixes compatibility regressions in computer modifier-key handling for computer actions. OpenAI's computer-use actions can include optional modifier keys on mouse actions, but adding
keysto the abstractComputerandAsyncComputermethod signatures broke released subclass implementations and made legacy drivers fail at runtime when the model emitted modifier-bearing actions.The change keeps the public driver override contract intact and moves modifier-key support into runtime dispatch. Mouse-action modifiers are forwarded only when a driver method accepts
keysor generic keyword arguments, while legacy drivers continue to run with a warning when modifiers are dropped. The built-in computer-use example now holds and releases modifier keys around mouse actions, and the test suite covers compatibility across legacy, modifier-aware, async,**kwargs, and batched-action paths.