fix: reduce sandbox sink buffering and spool timeouts#3642
Open
2830500285 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WorkspaceJsonlSinkmemory bounded to pending events by reading the existing workspace outbox during flush and clearing pending bytes after a successful writeHttpProxySinkevents whenurlopenraises a direct timeout/OSError delivery failureTest plan
uv run pytest tests/sandbox/test_session_sinks.py -q -k "clears_flushed_buffer or spools_direct_timeout"uv run pytest tests/sandbox/test_session_sinks.py -qmake syncUV_PROJECT_ENVIRONMENT=.venv_314 make syncUV_PROJECT_ENVIRONMENT=.venv_314 bash .agents/skills/code-change-verification/scripts/run.shIssue number
Closes #3640
Closes #3641
Checks
make lintandmake format